openstack service create allows duplicate names

[sandeep nandal]

$ openstack service create --name keystone --description "OpenStack Identity" identity
+-------------+----------------------------------+
| Field | Value |
+-------------+----------------------------------+
| description | OpenStack Identity |
| enabled | True |
| id | fbf58f4a39624bcf9c434a99e5e081fa |
| name | keystone |
| type | identity |
+-------------+----------------------------------+

$ openstack service create --name keystone --description "OpenStack Identity" identity
+-------------+----------------------------------+
| Field | Value |
+-------------+----------------------------------+
| description | OpenStack Identity |
| enabled | True |
| id | 7bd7431cbd2040a7a0d732560cbd4836 |
| name | keystone |
| type | identity |
+-------------+----------------------------------+

$ openstack service list
+----------------------------------+----------+----------+
| ID | Name | Type |
+----------------------------------+----------+----------+
| 7bd7431cbd2040a7a0d732560cbd4836 | keystone | identity |
| fbf58f4a39624bcf9c434a99e5e081fa | keystone | identity |
+----------------------------------+----------+----------+

Here we can see, that duplicate service names are created using openstack service create command.

[Steve Martinelli (stevemar)]

this is because the v2 API of keystone does not validate duplicate names, try the v3 APIs, it should.

[sandeep nandal (nandal)]

export OS_PROJECT_DOMAIN_ID=default
export OS_USER_DOMAIN_ID=default
export OS_PROJECT_NAME=admin
export OS_TENANT_NAME=admin
export OS_USERNAME=admin
export OS_PASSWORD=ADMIN_PASS
export OS_AUTH_URL=http://controller:35357/v3
export OS_IDENTITY_API_VERSION=3

These were the variables, when i used the above command, I hope it uses version 3 only

[sandeep nandal (nandal)]

openstack service create should complain about the duplicate entry and should not allow to add service with same name,
Because while using openstack service delete we can also provide the name of the service, and if we have duplicate service names,
then openstack service delete can not decide which entry to delete.

[Reedip (reedip-banerjee-deactivatedaccount)]

@sandeep nandal : Cant we use the ID of the service to delete it, even if the name is duplicated?

[Dean Troyer (dtroyer)]

OSC does not perform this sort of data validation. The server project make these decisions and the validation lies with them.

[Sheel Rana (ranasheel2000)]

Dear Steve,

I think this issue should be considered for keystone instead of OSC.
OSC does not validates names but keystone should validate names.

[Sheel Rana (ranasheel2000)]

I confirm this issue on V3.

sheel@sheel:~/openstackClient_SERVICE/python-openstackclient$ cat /home/sheel/Downloads/admin-openrc.sh
#!/usr/bin/env bash
export OS_AUTH_URL=http://10.0.2.15:5000/v3

sheel@sheel:~/openstackClient_SERVICE/python-openstackclient$ openstack service create --name keystone1 --description "OpenStack Identity" identity1
+-------------+----------------------------------+
| Field | Value |
+-------------+----------------------------------+
| description | OpenStack Identity |
| enabled | True |
| id | cbcb7f08bc7649aea8d878d64ecdf333 |
| name | keystone1 |
| type | identity1 |
+-------------+----------------------------------+
sheel@sheel:~/openstackClient_SERVICE/python-openstackclient$ openstack service create --name keystone1 --description "OpenStack Identity" identity1
+-------------+----------------------------------+
| Field | Value |
+-------------+----------------------------------+
| description | OpenStack Identity |
| enabled | True |
| id | 0f30443cf01747619b8ea2edcb2292d7 |
| name | keystone1 |
| type | identity1 |
+-------------+----------------------------------+
sheel@sheel:~/openstackClient_SERVICE/python-openstackclient$ openstack service list
+----------------------------------+-------------+----------------+
| ID | Name | Type |
+----------------------------------+-------------+----------------+
| 0f30443cf01747619b8ea2edcb2292d7 | keystone1 | identity1 |
| cbcb7f08bc7649aea8d878d64ecdf333 | keystone1 | identity1 |
+----------------------------------+-------------+----------------+

[David Stanek (dstanek)]

In Keystone we don't store the name in its own database column. We jam it into 'extras'. So we can't effectively enforce uniqueness.

[Steve Martinelli (stevemar)]

We can't enforce uniqueness with service names and types, and we can't break backward compatibility.