Create volume type fails, passes incorrect privacy argument

Bug #1520115 reported by Xi Yang on 2015-11-26
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Medium
Xi Yang

Bug Description

Currently the 'public' and 'private' are passed in when creating volume type, it is not correct. 'is_public' should be used:

    @utils.log_method(log)
    def take_action(self, parsed_args):

        volume_client = self.app.client_manager.volume

        kwargs = {}
        if parsed_args.public:
            kwargs['public'] = True
        if parsed_args.private:
            kwargs['private'] = True

Xi Yang (xi-yang) on 2015-11-26
Changed in python-openstackclient:
status: New → In Progress
assignee: nobody → Xi Yang (xi-yang)
Steve Martinelli (stevemar) wrote :
Changed in python-openstackclient:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/242855
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d1a58653ab8c3a98f2315ebbffd5e86be0beb966
Submitter: Jenkins
Branch: master

commit d1a58653ab8c3a98f2315ebbffd5e86be0beb966
Author: Xi Yang <yang.xi@99cloud.net>
Date: Sun Nov 8 23:22:51 2015 +0800

    Use is_public to set access of volume type

    Currently the 'public' and 'private' keys does not work
    when creating volume type, 'is_public' should be used.

    Change-Id: If34a66053ea6c192882a1b9d8bbb1d3666be3f83
    Closes-bug: 1520115

Changed in python-openstackclient:
status: In Progress → Fix Committed
summary: - Create volume type fails due to wrong parameter is passed
+ Create volume type fails, passes incorrect privacy argument
Changed in python-openstackclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers