Network Security Group Rule CRUD

Bug #1519512 reported by Terry Howe on 2015-11-24
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Medium
Richard Theis

Bug Description

Add support for neutron security group crud: create, delete and list. I'd recommend one patch per command.

Richard Theis (rtheis) on 2015-11-24
Changed in python-openstackclient:
assignee: nobody → Richard Theis (rtheis)
Changed in python-openstackclient:
importance: Undecided → Medium
status: New → Confirmed
tags: added: neutron

Fix proposed to branch: master
Review: https://review.openstack.org/261103

Changed in python-openstackclient:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/261103
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=7a1a59e5bb5a64dbeb91abdcac31dd0c8803c27d
Submitter: Jenkins
Branch: master

commit 7a1a59e5bb5a64dbeb91abdcac31dd0c8803c27d
Author: Richard Theis <email address hidden>
Date: Wed Dec 23 15:15:06 2015 -0600

    Functional tests for security group rule

    Add functional tests for the "security group rule" commands.

    Change-Id: Ia03886e92632f37a3d2625df1c3fa7c2a536c564
    Partial-Bug: #1519512
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/258684
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=96cc5eb3540e4753a8862020b2f6e78a465be4e2
Submitter: Jenkins
Branch: master

commit 96cc5eb3540e4753a8862020b2f6e78a465be4e2
Author: Richard Theis <email address hidden>
Date: Wed Dec 16 16:01:40 2015 -0600

    Add support to list all security group rules

    Both nova and neutron allow security group rules to be listed without
    specifying the owning security group. This patch set makes the
    group argument on 'os security group rule list' optional. Behavior
    is unchanged when the argument is specified. When the argument is
    not specified then all accessible security group rules will be listed.
    The listing will include the owning security group for each rule.

    Change-Id: I6914baecf70a65354e1e82dad92c6afbd32b4973
    Related-Bug: #1519512

Fix proposed to branch: master
Review: https://review.openstack.org/276800

Fix proposed to branch: master
Review: https://review.openstack.org/276888

Reviewed: https://review.openstack.org/276888
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=04e45bbacdcb17294454a85a835cc8393477aa27
Submitter: Jenkins
Branch: master

commit 04e45bbacdcb17294454a85a835cc8393477aa27
Author: Richard Theis <email address hidden>
Date: Fri Feb 5 13:39:40 2016 -0600

    Add NetworkAndCompute Lister and ShowOne classes

    This patch set introduces the NetworkAndComputeLister and
    NetworkAndComputeShowOne classes which are related to the
    NetworkAndComputeCommand class. These classes are for commands
    that must support neutron and nova network. The new classes
    allows both the parser and actions to be unique.

    Change-Id: I1b59264cd40aaf1062f4e8db233ccb7fd0e95f0e
    Partial-Bug: #1519511
    Partial-Bug: #1519512
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/276800
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=a83602341121ccd252a8eaaa390f387b5230cd75
Submitter: Jenkins
Branch: master

commit a83602341121ccd252a8eaaa390f387b5230cd75
Author: Richard Theis <email address hidden>
Date: Fri Feb 5 09:52:34 2016 -0600

    Refactor security group functional tests

    Moved the functional tests for "os security group" and
    "os security group rule" from the compute to the network
    directory to align with the refactoring to the commands.

    Change-Id: Ief6ab17775c6d7e3bef58d9fa025d9dd520b7370
    Partial-Bug: #1519511
    Partial-Bug: #1519512
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/276775
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=a29c9732d7434902fd36e0417e16bb760875591f
Submitter: Jenkins
Branch: master

commit a29c9732d7434902fd36e0417e16bb760875591f
Author: Richard Theis <email address hidden>
Date: Fri Feb 5 09:02:27 2016 -0600

    Refactor security group rule delete to use SDK

    Refactored the 'os security group rule delete' command to use the
    SDK when neutron is enabled, but continue to use the nova client
    when nova network is enabled.

    This patch set also introduces new FakeSecurityGroupRule classes
    for testing network and compute security group rules. And fixes
    were made to the network FakeSecurityGroup class.

    Change-Id: I8d0917925aa464e8255defae95a2a2adfb6cfb75
    Partial-Bug: #1519512
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/282525
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=dccde70c57baf9266a795a54198238515d7fdda6
Submitter: Jenkins
Branch: master

commit dccde70c57baf9266a795a54198238515d7fdda6
Author: Richard Theis <email address hidden>
Date: Fri Feb 19 10:19:28 2016 -0600

    Add "security group rule show" command

    Add the "os security group rule show" command which will use
    the SDK when neutron is enabled, and use the nova client when
    nova network is enabled.

    Change-Id: I41efaa4468ec15e4e86d74144cc72edc25a29024
    Partial-Bug: #1519512
    Implements: blueprint neutron-client

Fix proposed to branch: master
Review: https://review.openstack.org/296516

Reviewed: https://review.openstack.org/294118
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d90650796217fbb9cdd19297ee6ff59f0e009413
Submitter: Jenkins
Branch: master

commit d90650796217fbb9cdd19297ee6ff59f0e009413
Author: Richard Theis <email address hidden>
Date: Fri Mar 11 15:30:47 2016 -0600

    Refactor security group rule create to use SDK

    Refactored the 'os security group rule create' command to use the
    SDK when neutron is enabled, but continue to use the nova client
    when nova network is enabled.

    Added a release note for the change in security group rules output
    due to Network v2.

    Change-Id: I8c6c99d5272ff5d410a449f73d198d834c5cd96e
    Partial-Bug: #1519512
    Implements: blueprint neutron-client

Fix proposed to branch: master
Review: https://review.openstack.org/301744

Reviewed: https://review.openstack.org/296516
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=c5b58a47b0178cca0ab4a5b4a6329bd7ec9d42fa
Submitter: Jenkins
Branch: master

commit c5b58a47b0178cca0ab4a5b4a6329bd7ec9d42fa
Author: Richard Theis <email address hidden>
Date: Tue Mar 22 16:14:21 2016 -0500

    Refactor security group rule list to use SDK

    Refactored the 'os security group rule list' command to use the
    SDK when neutron is enabled, but continue to use the nova client
    when nova network is enabled.

    In addition, a release note was added to document the features
    and fixes resulting from this refactor.

    Change-Id: I24d04b720102ed1c60776e1ca67d4ca20e31b663
    Partial-Bug: #1519512
    Implements: blueprint neutron-client

Reviewed: https://review.openstack.org/300593
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=3a3f33b9265b63b681727f220d26286c763e67e3
Submitter: Jenkins
Branch: master

commit 3a3f33b9265b63b681727f220d26286c763e67e3
Author: Richard Theis <email address hidden>
Date: Thu Mar 31 16:19:20 2016 -0500

    Add network options to security group rule create

    Add the following network options to the "os security group rule"
    command:
      (1) --ingress and --egress
      (2) --ethertype
    These options enable egress and IPv6 security group rules for
    Network v2.

    Change-Id: Ie30b5e95f94e0c087b0ce81e518de72d2dda25ad
    Partial-Bug: #1519512
    Implements: blueprint neutron-client

Reviewed: https://review.openstack.org/301744
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=a5a9caea2b06a69953f692289866e59f52d78a4c
Submitter: Jenkins
Branch: master

commit a5a9caea2b06a69953f692289866e59f52d78a4c
Author: Richard Theis <email address hidden>
Date: Mon Apr 4 16:20:20 2016 -0500

    Add project options to security group rule create

    Add the --project and --project-domain options to the
    'os security group rule create' command. These options
    are for Network v2 only.

    Change-Id: Ie3e136be076f0f2c22fbe7048d1d6eaebf5aa655
    Partial-Bug: #1519512
    Implements: blueprint neutron-client

Reviewed: https://review.openstack.org/304297
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=94c9cd5c66512d52b31dfaa42bc3d1cc7fd81702
Submitter: Jenkins
Branch: master

commit 94c9cd5c66512d52b31dfaa42bc3d1cc7fd81702
Author: Richard Theis <email address hidden>
Date: Mon Apr 11 13:45:12 2016 -0500

    Add options to security group rule list

    Add the following options to the 'os security group rule list'
    command:
      --long: Display direction and ethertype for Network v2
      --all-projects: Display information from all projects for Compute v2

    Change-Id: If8a1cbd7669cdfa6577d6d2f6fffd9e999a39a82
    Partial-Bug: #1519512
    Implements: blueprint neutron-client

Reviewed: https://review.openstack.org/307908
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=fd5fd924d152338204fcf69673fedd31a3904977
Submitter: Jenkins
Branch: master

commit fd5fd924d152338204fcf69673fedd31a3904977
Author: Richard Theis <email address hidden>
Date: Fri Apr 15 07:36:43 2016 -0500

    Additional network protocol support

    Add the following network protocol support to the
    "os security group rule create" command:
      - Add "--icmp-type" and "--icmp-code" options
        for Network v2 only. These options can be used to set
        the ICMP type and code for ICMP IP protocols.
      - Change the "--proto" option to "--protocol". Using the
        "--proto" option is still supported, but is no longer
        documented and may be deprecated in a future release.
      - Add the following Network v2 IP protocols to the
        "--protocol" option: "ah", "dccp", "egp", "esp", "gre",
        "igmp", "ipv6-encap", "ipv6-frag", "ipv6-icmp",
        "ipv6-nonxt", "ipv6-opts", "ipv6-route", "ospf", "pgm",
        "rsvp", "sctp", "udplite", "vrrp" and integer
        representations [0-255].

    The "os security group rule list" command now supports
    displaying the ICMP type and code for security group rules
    with the ICMP IP protocols.

    Change-Id: Ic84bc92bc7aa5ac08f6ef91660eb6c125a200eb3
    Closes-Bug: #1519512
    Implements: blueprint neutron-client

Changed in python-openstackclient:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-openstackclient 2.5.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints