Network Security Group CRUD

[Terry Howe]

Add support for neutron security group crud: create, delete, show, list and set. I'd recommend one patch per command.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/252613

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/257543

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/261089

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261089
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=0e38ef84844ba406cb18fe3893dc6bebd205ef51
Submitter: Jenkins
Branch: master

commit 0e38ef84844ba406cb18fe3893dc6bebd205ef51
Author: Richard Theis <email address hidden>
Date: Wed Dec 23 13:44:22 2015 -0600

    Improve output for "os security group show"

    Improve the security group rules output when running the
    "os security group show" command. Each security group rule
    is now displayed on a separate line.

    Current output example:
    $ openstack security group show default
    +-------------+------------------------- ... ---+
    | Field | Value ... |
    +-------------+------------------------- ... ---+
    | description | Default security group ... |
    | id | 048a5fc3-3be1-407d-ae47-9... |
    | name | default ... |
    | project_id | 3b96bb2020c1459da76963f9e... |
    | rules | [u"id='5d812367-9829-4340...t"] |
    +-------------+------------------------- ... ---+

    New output example:
    +-------------+------------------------- ... ---+
    | Field | Value ... |
    +-------------+------------------------- ... ---+
    | description | Default security group ... |
    | id | 048a5fc3-3be1-407d-ae47-9... |
    | name | default ... |
    | project_id | 3b96bb2020c1459da76963f9e... |
    | rules | id='5d812367-9829-4340-95...lt' |
    | | id='ee451d1c-ade3-4975-8e...lt' |
    +-------------+------------------------- ... ---+

    Change-Id: I1386075310896c58a2b776e2bbec3603bd00eff1
    Partial-Bug: #1519511
    Related-To: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/263843

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263843
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=5ff660f71854bc4e11d7e37b6ed54c6170bedc10
Submitter: Jenkins
Branch: master

commit 5ff660f71854bc4e11d7e37b6ed54c6170bedc10
Author: Richard Theis <email address hidden>
Date: Tue Jan 5 12:33:11 2016 -0600

    Further improve output for "os security group show"

    Improve the security group rules output when running the
    "os security group show" command. Empty and duplicate
    information for each security group rule is now removed.
    This will ensure that the rules remain readable when
    direction and ethertype information is returned as part
    of the transition to neutron networking.

    Change-Id: Ib49c27a9d7f4d5d38ceb2b0d785ddf94d88b2d89
    Partial-Bug: #1519511
    Related-To: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/252613
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=57dac0bc3add71d6c491e2cecc60ef756b75ac32
Submitter: Jenkins
Branch: master

commit 57dac0bc3add71d6c491e2cecc60ef756b75ac32
Author: Richard Theis <email address hidden>
Date: Wed Dec 2 14:43:01 2015 -0600

    Refactor network endpoint enablement checking

    Move the network endpoint enablement checking from the 'server create'
    command to the common client manager. This allows future network
    commands to use either nova or neutron networking based on the cloud
    environment.

    This patch set also includes related unit test enhancements to the
    common client manager to trigger authentication on the tests.

    Change-Id: Ia37e81d4fb05a1e2fceb3e5d367bda769ab8e64b
    Related-Bug: #1519511
    Related-to: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/257543
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=580b0aff8810f234adcf364b0fe151b6e3c58182
Submitter: Jenkins
Branch: master

commit 580b0aff8810f234adcf364b0fe151b6e3c58182
Author: Richard Theis <email address hidden>
Date: Mon Dec 14 13:29:43 2015 -0600

    Refactor security group delete to use SDK

    Refactored the 'os security group delete' command to use the SDK
    when neutron is enabled, but continue to use the nova client when
    nova network is enabled.

    This patch set introduces a new NetworkAndComputeCommand class
    to be used for commands that must support neutron and nova network.
    The new class allows both the parser and actions to be unique.
    The current DeleteSecurityGroup class is now a subclass of this
    new class and has moved under the network v2 commands.

    This patch set also introduces a new FakeSecurityGroup class for
    testing security groups.

    And finally, this patch set updates the command documentation
    for security group and security group rule to indicate that
    Network v2 is also used.

    Change-Id: Ic21376b86b40cc6d97f360f3760ba5beed154537
    Partial-Bug: #1519511
    Related-to: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/276800

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/276888

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/278481

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/276888
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=04e45bbacdcb17294454a85a835cc8393477aa27
Submitter: Jenkins
Branch: master

commit 04e45bbacdcb17294454a85a835cc8393477aa27
Author: Richard Theis <email address hidden>
Date: Fri Feb 5 13:39:40 2016 -0600

    Add NetworkAndCompute Lister and ShowOne classes

    This patch set introduces the NetworkAndComputeLister and
    NetworkAndComputeShowOne classes which are related to the
    NetworkAndComputeCommand class. These classes are for commands
    that must support neutron and nova network. The new classes
    allows both the parser and actions to be unique.

    Change-Id: I1b59264cd40aaf1062f4e8db233ccb7fd0e95f0e
    Partial-Bug: #1519511
    Partial-Bug: #1519512
    Related-to: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/276800
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=a83602341121ccd252a8eaaa390f387b5230cd75
Submitter: Jenkins
Branch: master

commit a83602341121ccd252a8eaaa390f387b5230cd75
Author: Richard Theis <email address hidden>
Date: Fri Feb 5 09:52:34 2016 -0600

    Refactor security group functional tests

    Moved the functional tests for "os security group" and
    "os security group rule" from the compute to the network
    directory to align with the refactoring to the commands.

    Change-Id: Ief6ab17775c6d7e3bef58d9fa025d9dd520b7370
    Partial-Bug: #1519511
    Partial-Bug: #1519512
    Related-to: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/286275

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/278481
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=842882f3cbfca6df9a42bc49b0deefdb84509a8e
Submitter: Jenkins
Branch: master

commit 842882f3cbfca6df9a42bc49b0deefdb84509a8e
Author: Richard Theis <email address hidden>
Date: Tue Feb 9 07:21:01 2016 -0600

    Refactor security group list to use SDK

    Refactored the 'os security group list' command to use the SDK
    when neutron is enabled, but continue to use the nova client
    when nova network is enabled.

    This refactor also removes the logic for displaying project names
    instead of project IDs when the --all-projects option is specified.
    This logic was removed because it is inconsistent with the other
    network commands.

    Since neutron will always display security groups across all
    projects for an admin, the --all-projects option is now hidden
    when neutron is enabled and the Project column is always
    displayed.

    Change-Id: I934a1f5084ef3c5f929d0ffd38ebf5064d799941
    Partial-Bug: #1519511
    Related-to: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/286861

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/287763

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/287763
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=bac9fb18c1455f6a309e7acff9230a8d6bf7079b
Submitter: Jenkins
Branch: master

commit bac9fb18c1455f6a309e7acff9230a8d6bf7079b
Author: Richard Theis <email address hidden>
Date: Wed Mar 2 15:45:01 2016 -0600

    Refactor security group set to use SDK

    Refactored the 'os security group set' command to use the SDK
    when neutron is enabled, but continue to use the nova client
    when nova network is enabled.

    This patch set also fixes a compute bug which ignores name
    and description when set to an empty value.

    Change-Id: I4225179dca4aedf799e1656ec49236bdedc5e9bd
    Partial-Bug: #1519511
    Implements: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/288911

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/288911
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=46e86e5a4a8f147b02559d6e612a57bc7ced7171
Submitter: Jenkins
Branch: master

commit 46e86e5a4a8f147b02559d6e612a57bc7ced7171
Author: Richard Theis <email address hidden>
Date: Sat Mar 5 07:33:24 2016 -0600

    Add release note for security group set refactor

    Add a release note for [1].

    [1] https://review.openstack.org/#/c/287763/

    Change-Id: I30812c3ead477267dc7e3dc774c09b3435152eb9
    Partial-Bug: #1519511
    Implements: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/286275
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=564c8ff2403da87b96562076865f42426a4f8eac
Submitter: Jenkins
Branch: master

commit 564c8ff2403da87b96562076865f42426a4f8eac
Author: Richard Theis <email address hidden>
Date: Fri Feb 26 11:33:45 2016 -0600

    Refactor security group show to use SDK

    Refactored the 'os security group show' command to use the SDK
    when neutron is enabled, but continue to use the nova client
    when nova network is enabled.

    Added a release note for the change in security group rules output
    due to Network v2. The column names remain unchanged to maintain
    backwards compatibility.

    Change-Id: I25233ddb8115d18b8b88affb3de13346084a339d
    Partial-Bug: #1519511
    Implements: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/286861
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=ea2dd8e141ef1cf446a42ee93992d8fb44f4ba05
Submitter: Jenkins
Branch: master

commit ea2dd8e141ef1cf446a42ee93992d8fb44f4ba05
Author: Richard Theis <email address hidden>
Date: Tue Mar 1 15:34:35 2016 -0600

    Refactor security group create to use SDK

    Refactored the 'os security group create' command to use the SDK
    when neutron is enabled, but continue to use the nova client
    when nova network is enabled.

    Added a release note for the change in security group rules output
    due to Network v2. The tenant_id column name was fixed to align
    with the 'os security group show' command.

    Change-Id: Ib29df42edcddcc73a123fff6a64743a6bfcb7fbf
    Partial-Bug: #1519511
    Implements: blueprint neutron-client

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/291736

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/291736
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=a7c76878da02da406c9ccbcd62cc40def1108faa
Submitter: Jenkins
Branch: master

commit a7c76878da02da406c9ccbcd62cc40def1108faa
Author: Richard Theis <email address hidden>
Date: Fri Mar 11 08:11:12 2016 -0600

    Add project options to security group create

    Add the --project and --project-domain options to the
    'os security group create' command. These options are for Network v2
    only.

    Change-Id: I9e1667080a1a49389d51ade2e76a08b08a09870b
    Closes-Bug: #1519511
    Implements: blueprint neutron-client

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-openstackclient 2.4.0 release.