Network Floating IP CRUD

Bug #1519502 reported by Terry Howe on 2015-11-24
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Medium
Tang Chen

Bug Description

Add support for neutron floating IP crud: add, create, delete, list and remove. I'd recommend one patch per command.

Changed in python-openstackclient:
assignee: nobody → Jude Augustine Job (judeaugustine-j)
Changed in python-openstackclient:
status: New → In Progress
Changed in python-openstackclient:
importance: Undecided → Medium
tags: added: neutron
Tang Chen (tangchen) wrote :

Hi,

I'd like to help with this bug. I assign it to myself, but I cannot bring Jude Augustine Job back because I have not right to do so...... Is it possible to assign a bug to more than one developer ?

Thanks.

Changed in python-openstackclient:
assignee: Jude Augustine Job (judeaugustine-j) → Tang Chen (tangchen)
Steve Martinelli (stevemar) wrote :

@Tang, bugs are first come first serve - go ahead and toss up a patch!

there is no way to assign 2 people to a bug

Steve Martinelli (stevemar) wrote :

@Tang, if you want to post a new revision to https://review.openstack.org/#/c/258519/, please do so and add yourself as a co-author, this way both you and Jude are credited for fixing the bug. Hope this helps, ping me on IRC if you need more guidance.

Fix proposed to branch: master
Review: https://review.openstack.org/277720

Reviewed: https://review.openstack.org/258519
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=6109dfcf63a666330e7323d957a37a251dd2b520
Submitter: Jenkins
Branch: master

commit 6109dfcf63a666330e7323d957a37a251dd2b520
Author: Jude Job <email address hidden>
Date: Tue Feb 2 09:35:38 2016 +0530

    Floating IP: Neutron support for "ip floating delete" command

    This patch implements "ip floating delete" command for
    both compute and network. Also includes unit tests.

    Change-Id: Ie61f0faad65ec90f9d9956ae463412be8d963d05
    partial-Bug: 1519502
    Related-to: blueprint neutron-client
    Co-Authored-By: Tang Chen <email address hidden>

Reviewed: https://review.openstack.org/277720
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d8abec33ada8b2b028d52eb8bfad2640812b9af8
Submitter: Jenkins
Branch: master

commit d8abec33ada8b2b028d52eb8bfad2640812b9af8
Author: Tang Chen <email address hidden>
Date: Tue Feb 9 14:23:28 2016 +0800

    Floating IP: Neutron support for "ip floating list" command

    Change-Id: I253f66f6bc64470e1a18ffea506048eb53f67d5c
    partial-Bug: 1519502
    Related-to: blueprint neutron-client

Fix proposed to branch: master
Review: https://review.openstack.org/280534

Fix proposed to branch: master
Review: https://review.openstack.org/280535

Reviewed: https://review.openstack.org/280534
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=da3d65299bc168ca86bfb4055d08556715149e0f
Submitter: Jenkins
Branch: master

commit da3d65299bc168ca86bfb4055d08556715149e0f
Author: Tang Chen <email address hidden>
Date: Tue Feb 16 15:11:19 2016 +0800

    Define FakeFloatingIP class in tests/compute for nova network commands

    "ip floating list" command is not available for Neutron now because
    the implementation is incorrect.

    The FloatingIP objects returned from Nova and Neutron network are
    quite different. So they need different FakeFloatingIP class to
    do the tests.

    This patch copies class FakeFloatingIP in tests/network to tests/compute
    for Nova network tests.

    Will fix the problem in "ip floating list" command and change FakeFloatingIP
    in tests/network to fit Neutron network tests.

    Change-Id: Ia29d257868e0f1dc6cd7cfe3819875e5913f76ec
    Partial-Bug: 1519502
    Partially implements: blueprint neutron-client

Reviewed: https://review.openstack.org/280498
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=5f40e1ea451558b7db904661151a6d353e2c02f5
Submitter: Jenkins
Branch: master

commit 5f40e1ea451558b7db904661151a6d353e2c02f5
Author: Tang Chen <email address hidden>
Date: Tue Feb 16 13:34:13 2016 +0800

    Add release note for "ip floating delete/list" commands for neutron network

    Change-Id: Ic90abf106a06edf9af4fe4c8938ab92bfdd8bb42
    partial-Bug: 1519502
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/280535
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=ca34aa1587212ce5ac456a988fd6b442e646ed16
Submitter: Jenkins
Branch: master

commit ca34aa1587212ce5ac456a988fd6b442e646ed16
Author: Tang Chen <email address hidden>
Date: Tue Feb 16 14:33:31 2016 +0800

    Floating IP: Fix "ip floating list" in neutron network

    The implementation of "ip floating list" in the commit below
    is incorrect:

        Change-Id: I253f66f6bc64470e1a18ffea506048eb53f67d5c

    This is because the FloatingIP objects returned from Nova and
    Neutron network are different. They need different handling.

    This patch fixes this problem.

    The output for Neutron network would be:

    +--------------------------------------+---------------------+------------------+------+
    | ID | Floating IP Address | Fixed IP Address | Port |
    +--------------------------------------+---------------------+------------------+------+
    | 1976df86-e66a-4f96-81bd-c6ffee6407f1 | 172.24.4.3 | None | None |
    +--------------------------------------+---------------------+------------------+------+

    The output for Neutron network would be:

    +----+---------------------+------------------+-----------+--------+
    | ID | Floating IP Address | Fixed IP Address | Server ID | Pool |
    +----+---------------------+------------------+-----------+--------+
    | 1 | 172.24.4.1 | None | None | public |
    +----+---------------------+------------------+-----------+--------+

    Change-Id: I1295e922df695414511d9a07ca4a8e2428040064
    Partial-Bug: 1519502
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/284020
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=f0960f0fef263298e56d7e81acf50597073becc7
Submitter: Jenkins
Branch: master

commit f0960f0fef263298e56d7e81acf50597073becc7
Author: Tang Chen <email address hidden>
Date: Wed Feb 24 17:26:13 2016 +0800

    Floating IP: Neutron support for "ip floating show" command

    Change-Id: I30350076621c83c758927444e5f8bcc2b7d0fc74
    Partial-Bug: 1519502
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/291602
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=515cc87174e1ea150c77e63bb8e17b007dde44d1
Submitter: Jenkins
Branch: master

commit 515cc87174e1ea150c77e63bb8e17b007dde44d1
Author: Tang Chen <email address hidden>
Date: Fri Mar 11 16:38:48 2016 +0800

    Add incompatibility info for "ip floating list" command

    Commit d8abec33ada8b2b028d52eb8bfad2640812b9af8 changed
    the output of "ip floating list" command. But forgot to
    add any backward incompatibility info.

    Output of command "ip floating list" for nova network
    has been changed. And it is different from the output
    of neutron network.

    This patch adds this incompatibility info.

    Change-Id: I45858fda3b9bcc0bdf4d0891637fa7dd712872af
    Partial-Bug: 1519502
    Related-to: blueprint neutron-client

Reviewed: https://review.openstack.org/288441
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=860dbc132d512c6df16d29875bb6388d10d9fab8
Submitter: Jenkins
Branch: master

commit 860dbc132d512c6df16d29875bb6388d10d9fab8
Author: Tang Chen <email address hidden>
Date: Thu Mar 3 17:17:40 2016 +0800

    [Floating IP] Neutron support for "ip floating create" command

    This patch adds --subnet, --port, --floating-ip-address
    and --fixed-ip-address options only. Project related options
    will be added in another patch because it relates to identity
    v2 and v3, which will make the unit tests too complicated in
    one single patch.

    Change-Id: I3cce4404a114ff128b74e4596f0e847be2846b17
    Partial-Bug: 1519502
    Related-to: blueprint neutron-client

Richard Theis (rtheis) wrote :

Hi Tang, Is this done given the refactor work being done (https://bugs.launchpad.net/python-openstackclient/+bug/1555990)?

Richard Theis (rtheis) wrote :

Hi Tang, following up on whether or not this is done given the refactor work.

Tang Chen (tangchen) wrote :

Hi Richard,

have linked this bug to the patches.

Tang Chen (tangchen) wrote :

Hi Richard, Steve, Dean,

I think we can close this bug, and just use bug 1555990 to track the rework.

Richard Theis (rtheis) wrote :

Thanks Tang. I'll mark this as fix released.

Changed in python-openstackclient:
status: In Progress → Fix Released

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/381506

Change abandoned by venkata anil (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/381506
Reason: As this backport is not allowed. Please see comments from reviewers

Change abandoned by venkata anil (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/381424
Reason: As this backport is not allowed. Please see comments from reviewers

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers