Network Floating IP CRUD
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | python-openstackclient |
Fix Released
|
Medium
|
Tang Chen | |
Bug Description
Add support for neutron floating IP crud: add, create, delete, list and remove. I'd recommend one patch per command.
| Changed in python-openstackclient: | |
| assignee: | nobody → Jude Augustine Job (judeaugustine-j) |
| Changed in python-openstackclient: | |
| status: | New → In Progress |
| Changed in python-openstackclient: | |
| importance: | Undecided → Medium |
| tags: | added: neutron |
| Tang Chen (tangchen) wrote : | #2 |
Hi,
I'd like to help with this bug. I assign it to myself, but I cannot bring Jude Augustine Job back because I have not right to do so...... Is it possible to assign a bug to more than one developer ?
Thanks.
| Changed in python-openstackclient: | |
| assignee: | Jude Augustine Job (judeaugustine-j) → Tang Chen (tangchen) |
| Steve Martinelli (stevemar) wrote : | #3 |
@Tang, bugs are first come first serve - go ahead and toss up a patch!
there is no way to assign 2 people to a bug
| Steve Martinelli (stevemar) wrote : | #4 |
@Tang, if you want to post a new revision to https:/
| OpenStack Infra (hudson-openstack) wrote : | #5 |
Fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 6109dfcf63a6663
Author: Jude Job <email address hidden>
Date: Tue Feb 2 09:35:38 2016 +0530
Floating IP: Neutron support for "ip floating delete" command
This patch implements "ip floating delete" command for
both compute and network. Also includes unit tests.
Change-Id: Ie61f0faad65ec9
partial-Bug: 1519502
Related-to: blueprint neutron-client
Co-Authored-By: Tang Chen <email address hidden>
| OpenStack Infra (hudson-openstack) wrote : | #7 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit d8abec33ada8b2b
Author: Tang Chen <email address hidden>
Date: Tue Feb 9 14:23:28 2016 +0800
Floating IP: Neutron support for "ip floating list" command
Change-Id: I253f66f6bc6447
partial-Bug: 1519502
Related-to: blueprint neutron-client
Fix proposed to branch: master
Review: https:/
| OpenStack Infra (hudson-openstack) wrote : | #9 |
Fix proposed to branch: master
Review: https:/
Fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit da3d65299bc168c
Author: Tang Chen <email address hidden>
Date: Tue Feb 16 15:11:19 2016 +0800
Define FakeFloatingIP class in tests/compute for nova network commands
"ip floating list" command is not available for Neutron now because
the implementation is incorrect.
The FloatingIP objects returned from Nova and Neutron network are
quite different. So they need different FakeFloatingIP class to
do the tests.
This patch copies class FakeFloatingIP in tests/network to tests/compute
for Nova network tests.
Will fix the problem in "ip floating list" command and change FakeFloatingIP
in tests/network to fit Neutron network tests.
Change-Id: Ia29d257868e0f1
Partial-Bug: 1519502
Partially implements: blueprint neutron-client
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 5f40e1ea451558b
Author: Tang Chen <email address hidden>
Date: Tue Feb 16 13:34:13 2016 +0800
Add release note for "ip floating delete/list" commands for neutron network
Change-Id: Ic90abf106a06ed
partial-Bug: 1519502
Related-to: blueprint neutron-client
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit ca34aa1587212ce
Author: Tang Chen <email address hidden>
Date: Tue Feb 16 14:33:31 2016 +0800
Floating IP: Fix "ip floating list" in neutron network
The implementation of "ip floating list" in the commit below
is incorrect:
Change-Id: I253f66f6bc6447
This is because the FloatingIP objects returned from Nova and
Neutron network are different. They need different handling.
This patch fixes this problem.
The output for Neutron network would be:
+--
| ID | Floating IP Address | Fixed IP Address | Port |
+--
| 1976df86-
+--
The output for Neutron network would be:
+--
| ID | Floating IP Address | Fixed IP Address | Server ID | Pool |
+--
| 1 | 172.24.4.1 | None | None | public |
+--
Change-Id: I1295e922df6954
Partial-Bug: 1519502
Related-to: blueprint neutron-client
Fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit f0960f0fef26329
Author: Tang Chen <email address hidden>
Date: Wed Feb 24 17:26:13 2016 +0800
Floating IP: Neutron support for "ip floating show" command
Change-Id: I30350076621c83
Partial-Bug: 1519502
Related-to: blueprint neutron-client
Fix proposed to branch: master
Review: https:/
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 515cc87174e1ea1
Author: Tang Chen <email address hidden>
Date: Fri Mar 11 16:38:48 2016 +0800
Add incompatibility info for "ip floating list" command
Commit d8abec33ada8b2b
the output of "ip floating list" command. But forgot to
add any backward incompatibility info.
Output of command "ip floating list" for nova network
has been changed. And it is different from the output
of neutron network.
This patch adds this incompatibility info.
Change-Id: I45858fda3b9bcc
Partial-Bug: 1519502
Related-to: blueprint neutron-client
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 860dbc132d512c6
Author: Tang Chen <email address hidden>
Date: Thu Mar 3 17:17:40 2016 +0800
[Floating IP] Neutron support for "ip floating create" command
This patch adds --subnet, --port, --floating-
and --fixed-ip-address options only. Project related options
will be added in another patch because it relates to identity
v2 and v3, which will make the unit tests too complicated in
one single patch.
Change-Id: I3cce4404a114ff
Partial-Bug: 1519502
Related-to: blueprint neutron-client
| Richard Theis (rtheis) wrote : | #19 |
Hi Tang, Is this done given the refactor work being done (https:/
| Richard Theis (rtheis) wrote : | #20 |
Hi Tang, following up on whether or not this is done given the refactor work.
| Tang Chen (tangchen) wrote : | #21 |
Hi Richard,
have linked this bug to the patches.
| Tang Chen (tangchen) wrote : | #22 |
Hi Richard, Steve, Dean,
I think we can close this bug, and just use bug 1555990 to track the rework.
| Richard Theis (rtheis) wrote : | #23 |
Thanks Tang. I'll mark this as fix released.
| Changed in python-openstackclient: | |
| status: | In Progress → Fix Released |
| OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (stable/mitaka) | #24 |
Fix proposed to branch: stable/mitaka
Review: https:/
Fix proposed to branch: stable/mitaka
Review: https:/
| OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-openstackclient (stable/mitaka) | #26 |
Change abandoned by venkata anil (<email address hidden>) on branch: stable/mitaka
Review: https:/
Reason: As this backport is not allowed. Please see comments from reviewers
Change abandoned by venkata anil (<email address hidden>) on branch: stable/mitaka
Review: https:/
Reason: As this backport is not allowed. Please see comments from reviewers
Fix proposed to branch: master
Review: https:/