Functional tests should not use environment variables

[Terry Howe]

Functional tests should probably not use environment variables at all. An environment variable set in one test may effect another test and it may be different to detect that there is a problem. Right now we are setting OS_VOLUME_API_VERSION=1, but if that same environmebnt is used to run a v2 test after that, it will run v1 and we might never know. I would think that using the --os-volume-api-version.

[Vincent Legoll (vincent-legoll)]

Maybe still allow env. vars usage for tests, but ensure that a clean env is given to each test (fixture ?)

[Steve Martinelli (stevemar)]

Unassigning due to inactivity.

Vincent, yes, ideally a fixture would be used instead.

[Vincent Legoll (vincent-legoll)]

@stevemar: would this be worth working on ?

I ask because, I recently added an env var to cliff with tests that are fixturized with
@mock.patch.dict(os.environ, {'XXX_ENV_VAR': 'YYY_VAL'})

If this is worthwhile, I can dig through code and fix what I can find...

looks like parts of it are already fixtures : openstackclient/tests/test_shell.py
but others may miss a tearDownClass(), like functional/tests/volume/v1/common.py

Is that the way to fix this ?

[Vincent Legoll (vincent-legoll)]

Here is a patch for the cases I found, if this is the way to go, I'll put that through gerrit...

[Vincent Legoll (vincent-legoll)]

Patch on gerrit for review:
https://review.openstack.org/#/c/333807/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Vincent Legoll (<email address hidden>) on branch: master
Review: https://review.openstack.org/333807
Reason: not enough time