image set v2 uses visibility option instead of public and private

[Terry Howe]

The image set command for v2 uses visibility option instead of --public|--private

Also investigate --protected|--unprotected.

Add notes to barkward-incompatiblity, deprecate old options.

[Sean Perry (sean-perry-a)]

I do not mind converting --visibility to public/private. Consistency with others does have value.

But --unprotected is bad UX in my opinion. If --protected is not provided the value is False. --unprotected performs no useful function. You are always 'unprotected' unless you use --protected. Why provide a parameter that never needs to be used?

[Sean Perry (sean-perry-a)]

Right, we need --unprotected to reverse a request for protection. Makes total sense on the set command.

[Steve Martinelli (stevemar)]

i think we can close this out, we settled on using --private or --public, as we do with the volume related commands.

https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v2/image.py#L180-L190

this is used for both image v1 and v2.

[Steve Martinelli (stevemar)]

dupe of https://bugs.launchpad.net/python-openstackclient/+bug/1405562

[Lin Hua Cheng (lin-hua-cheng)]

bug resolved by this patch: https://review.openstack.org/#/c/226232/