type should be volume_type

Bug #1475958 reported by jiaxi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Low
Steve Martinelli

Bug Description

openstackclient/volume/v1/type.py

The name should be type.py should be changed to be volume_type.py as v2 did.

Because type is too general.Many obeject has a type.

jiaxi (tjxiter)
Changed in python-openstackclient:
assignee: nobody → jiaxi (tjxiter)
Revision history for this message
Terry Howe (thowe-g) wrote :

Those files are in different modules. I don't understand why the file names need to be unique.

Revision history for this message
jiaxi (tjxiter) wrote :

@Terry Howe (thowe-g)

I means that type is not good .Three reason:
1. too general
2. built_in words
3. If some object like volume has type, for example : snapshot type,do you want to name it as type1.py or snapshot_type.py ?

Revision history for this message
Steve Martinelli (stevemar) wrote :

Terry, I actually agree with this bug. For v2 we named it volume_type as well. There won't be any user facing changes either, so I'm good with it.

Changed in python-openstackclient:
status: New → In Progress
importance: Undecided → Low
assignee: jiaxi (tjxiter) → Steve Martinelli (stevemar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/203435

Revision history for this message
Steve Martinelli (stevemar) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/203435
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=11c9695e5ef127d0c99e2af610e462f5b1af4933
Submitter: Jenkins
Branch: master

commit 11c9695e5ef127d0c99e2af610e462f5b1af4933
Author: Steve Martinelli <email address hidden>
Date: Sun Jul 19 08:54:50 2015 -0700

    Rename type.py to volume_type.py

    For Volume V1, we have a type.py file which should be renamed to
    volume_type.py (as it's named for V2).

    Change-Id: If860bbafe4a801d8b4fa06938eef20658c4fcc2c
    Closes-Bug: 1475958

Changed in python-openstackclient:
status: In Progress → Fix Committed
Changed in python-openstackclient:
milestone: none → 1.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.