image create skips location attribute

Bug #1445460 reported by Marek Aufart
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Unassigned

Bug Description

There is a location attribute in image create action, but in method body only listed attributes are passed to glance call and location is not there (just localtion - so propably typo).

The result is that image file specified in location attribute is not passed to glance create image call, so image is empty.

Expected fix is to correct localtion to location - https://github.com/openstack/python-openstackclient/blob/master/openstackclient/image/v1/image.py#L193

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/174848
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d363068617ea37cf17583c390df69f3bbe7ff45c
Submitter: Jenkins
Branch: master

commit d363068617ea37cf17583c390df69f3bbe7ff45c
Author: Marek Aufart <email address hidden>
Date: Fri Apr 17 14:20:37 2015 +0200

    Fix skipped image create attribute location attr

    Image create action accepts attribute called location,
    in method body is list of allowed attributes, which contain
    localtion, what is typo and this attribute was not passed to
    glance. Fixed.

    Change-Id: I357b06b63b8aa97f7a5f587ef3fcee7a4b360ed1
    Closes-Bug: #1445460

Changed in python-openstackclient:
status: New → Fix Committed
Dean Troyer (dtroyer)
Changed in python-openstackclient:
milestone: none → m10
Dean Troyer (dtroyer)
Changed in python-openstackclient:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstackclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/191043

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-openstackclient (stable/kilo)

Change abandoned by Tony Breeds (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/191043
Reason: This review is being abandoned as the stable/kilo will go End-Of-Life (EOL) in the near future.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.