python-openstackclient

Better error message for sort_items

Bug #1420732 reported by Zhiyuan Cai
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Undecided
Zhiyuan Cai
python-openstackclient m8 "oxygen"

Bug Description

Currently if users pass wrong sort diretion when using --sort argument, client will only inform users that "asc" and "desc" are the correct ones. It will be more helpful if client informs users which sort direction for which sort key they specify is wrong.

Zhiyuan Cai (luckyvega-g)
Changed in python-openstackclient:
assignee: nobody → Zhiyuan Cai (luckyvega-g)
OpenStack Infra (hudson-openstack)
Changed in python-openstackclient:
status: New → In Progress
Revision history for this message
Steve Martinelli (stevemar) wrote :

link the patch?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/154741
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=d13023b32a990241a4a0ebb7fb2dab5391c003e3
Submitter: Jenkins
Branch: master

commit d13023b32a990241a4a0ebb7fb2dab5391c003e3
Author: zhiyuan_cai <email address hidden>
Date: Wed Feb 11 10:35:10 2015 +0800

    Fix error msg in sort_items

    Include direction users pass in the error msg to help users know
    which part of the argument is troublesome.

    Change-Id: I796a85fbf40f6ddf544fb52a61f967e1914abdcc
    Closes-Bug: #1420732

Changed in python-openstackclient:
status: In Progress → Fix Committed
Dean Troyer (dtroyer)
Changed in python-openstackclient:
milestone: none → m8
Dean Troyer (dtroyer)
Changed in python-openstackclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.