functional tests are failing with new keystoneclient release

[Steve Martinelli]

test_osc_lib and test_object_store examples are failing because of a new keystoneclient release

 DEBUG: requests.packages.urllib3.connectionpool "GET /v1/AUTH_270bb12e8d184ff2823fd66717d3c302?format=json HTTP/1.1" 200 2
2015-02-10 01:06:06.139 | 2015-02-10 01:06:06.118 | ERROR: common Traceback (most recent call last):
2015-02-10 01:06:06.140 | 2015-02-10 01:06:06.120 | File "/opt/stack/new/python-openstackclient/examples/common.py", line 259, in main
2015-02-10 01:06:06.142 | 2015-02-10 01:06:06.121 | return run(opts)
2015-02-10 01:06:06.143 | 2015-02-10 01:06:06.123 | File "/opt/stack/new/python-openstackclient/examples/object_api.py", line 85, in run
2015-02-10 01:06:06.145 | 2015-02-10 01:06:06.124 | c_list = obj_api.container_list()
2015-02-10 01:06:06.146 | 2015-02-10 01:06:06.126 | File "/opt/stack/new/python-openstackclient/openstackclient/api/object_store_v1.py", line 127, in container_list
2015-02-10 01:06:06.148 | 2015-02-10 01:06:06.127 | return self.list('', **params)
2015-02-10 01:06:06.149 | 2015-02-10 01:06:06.128 | File "/opt/stack/new/python-openstackclient/openstackclient/api/api.py", line 196, in list
2015-02-10 01:06:06.153 | 2015-02-10 01:06:06.130 | params=params,
2015-02-10 01:06:06.172 | 2015-02-10 01:06:06.131 | File "/opt/stack/new/python-openstackclient/openstackclient/api/api.py", line 82, in _request
2015-02-10 01:06:06.172 | 2015-02-10 01:06:06.133 | return session.request(url, method, **kwargs)
2015-02-10 01:06:06.172 | 2015-02-10 01:06:06.134 | File "/opt/stack/new/python-openstackclient/.tox/functional/local/lib/python2.7/site-packages/keystoneclient/utils.py", line 318, in inner
2015-02-10 01:06:06.173 | 2015-02-10 01:06:06.136 | return func(*args, **kwargs)
2015-02-10 01:06:06.173 | 2015-02-10 01:06:06.137 | File "/opt/stack/new/python-openstackclient/.tox/functional/local/lib/python2.7/site-packages/keystoneclient/session.py", line 369, in request
2015-02-10 01:06:06.173 | 2015-02-10 01:06:06.138 | resp = send(**kwargs)
2015-02-10 01:06:06.173 | 2015-02-10 01:06:06.139 | File "/opt/stack/new/python-openstackclient/.tox/functional/local/lib/python2.7/site-packages/keystoneclient/session.py", line 428, in _send_request
2015-02-10 01:06:06.173 | 2015-02-10 01:06:06.141 | self._http_log_response(response=resp)
2015-02-10 01:06:06.173 | 2015-02-10 01:06:06.142 | File "/opt/stack/new/python-openstackclient/.tox/functional/local/lib/python2.7/site-packages/keystoneclient/utils.py", line 318, in inner
2015-02-10 01:06:06.174 | 2015-02-10 01:06:06.143 | return func(*args, **kwargs)
2015-02-10 01:06:06.174 | 2015-02-10 01:06:06.145 | File "/opt/stack/new/python-openstackclient/.tox/functional/local/lib/python2.7/site-packages/keystoneclient/session.py", line 204, in _http_log_response
2015-02-10 01:06:06.174 | 2015-02-10 01:06:06.146 | text = remove_service_catalog(response.text)
2015-02-10 01:06:06.174 | 2015-02-10 01:06:06.147 | File "/opt/stack/new/python-openstackclient/.tox/functional/local/lib/python2.7/site-packages/keystoneclient/session.py", line 63, in remove_service_catalog
2015-02-10 01:06:06.174 | 2015-02-10 01:06:06.149 | if 'catalog' in data['token']:
2015-02-10 01:06:06.174 | 2015-02-10 01:06:06.150 | TypeError: list indices must be integers, not str

http://logs.openstack.org/22/153922/2/check/check-osc-dsvm-functional/2452e86/console.html

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/154323

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/154323
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=3946bf0e0186c8c2897f432029bad7873b6d03a0
Submitter: Jenkins
Branch: master

commit 3946bf0e0186c8c2897f432029bad7873b6d03a0
Author: Steve Martinelli <email address hidden>
Date: Mon Feb 9 22:05:51 2015 -0500

    Skip functional tests until they are fixed

    Newest python-keystoneclient broke some of our tests, this patch
    is just to get the gate less broken.

    Change-Id: I8961c63d094e9effde73f6d4088d8626a46e1f3d
    Related-Bug: #1420080

[Brant Knudson (blk-u)]

I think this is related to this change in python-keystoneclient : https://review.openstack.org/#/c/145532/ . Not sure why since I don't know what the token looked like.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/155605

[Brant Knudson (blk-u)]

Proposed https://review.openstack.org/#/c/155605/ to keystoneclient.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/155605
Committed: https://git.openstack.org/cgit/openstack/python-keystoneclient/commit/?id=ae784225627f1652638edc0bf273a41519a438d5
Submitter: Jenkins
Branch: master

commit ae784225627f1652638edc0bf273a41519a438d5
Author: Brant Knudson <email address hidden>
Date: Thu Feb 12 20:18:07 2015 -0600

    Ignore all failures removing catalog when logging token

    Operations could fail if the response was logged and had a 'token'
    field that's not a dict. The fix is to ignore all errors when
    trying to remove the service catalog from the response.

    Also, enhanced the service catalog removal code to support V2
    tokens.

    Closes-Bug: 1420080
    Change-Id: I35b971415744825e8e5f00f30dcf193d04ee699a

[Dean Troyer (dtroyer)]

https://review.openstack.org/#/c/156449/ restored the functional tests