Compute region selection broken

[Terry Howe]

Region selection for compute is not working from environment variables or command line options. The region is not passed to the get_endpoint call to select the endpoint.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/143835

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/143835
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=1927b03cc740378fcc1d146803cee988ec93e6a2
Submitter: Jenkins
Branch: master

commit 1927b03cc740378fcc1d146803cee988ec93e6a2
Author: Terry Howe <email address hidden>
Date: Wed Dec 24 06:08:19 2014 -0700

    Compute calls ignore region selection

    Calls to compute commands ignore region selection. The region is
    not passed to the get_endpoint call.

    Change-Id: I1ccfc56d7cb27a00b8982232a40ace21f2c0e9a2
    Closes-Bug: 1405416

[Andrey Larionov (anlarionov)]

When we can expect a release with this fix? It's show stopper for adoption, because our installation have 7 regions, and this bug made client usesless.

[Terry Howe (thowe-g)]

I can't answer your question, but this is the patch I've been using as a work-around (in a virtualenv):

patch ~/.venv/lib/python2.7/site-packages/openstackclient/compute/client.py <<!
diff --git a/openstackclient/compute/client.py b/openstackclient/compute/client.py
index 3725350..166747d 100644
--- a/openstackclient/compute/client.py
+++ b/openstackclient/compute/client.py
@@ -50,6 +50,7 @@ def make_client(instance):
         extensions=extensions,
         http_log_debug=http_log_debug,
         timings=instance.timing,
+ region_name=instance._region_name,
     )

     return client
!

[Steve Martinelli (stevemar)]

we should be releasing 1.0.2 (m7) fairly soon, the fix is already in the code base.

[Andrey Larionov (anlarionov)]

Thanks. Steve.

[Eric (erichelgeson)]

This was not fixed for volumes region selection, same bug, same fix. I made a PR on github, but since you don't use that and it's a one line change I'll let you fix it :) You can add a CONTRIBUTING.md file to your repo to show a warning when people create pull requests on github.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/148811

[Steve Martinelli (stevemar)]

Thanks Eric, I put up this patch: https://review.openstack.org/#/c/148811/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/148811
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=5e43120d43d6b12d76f759473eaf6e8e82a4ca27
Submitter: Jenkins
Branch: master

commit 5e43120d43d6b12d76f759473eaf6e8e82a4ca27
Author: Steve Martinelli <email address hidden>
Date: Wed Jan 21 01:52:20 2015 -0500

    Add region name for identity and volume clients

    We do not take into account region names for identity and volume
    clients.

    Change-Id: I4263e9013226b0adc6b9ad7540d6ad3efb42e809
    Co-Authored-By: Eric Helgeson <email address hidden>
    Related-Bug: #1405416