functional tests fail if a cirros*-uec image isn't found

Bug #1614118 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
High
Ukesh
Liberty
Fix Committed
High
Matt Riedemann
Mitaka
Fix Committed
High
Matt Riedemann

Bug Description

The functional tests are looking for a cirros-*uec image and if that isn't found they fail:

https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/functional/base.py#L61

This is based on the images that devstack loads up today:

stack@sulmer:~$ glance image-list
+--------------------------------------+---------------------------------+
| ID | Name |
+--------------------------------------+---------------------------------+
| 4e22f46f-bb7a-413c-839c-6317abf3ca8d | cirros-0.3.4-x86_64-uec |
| 515b61cd-abe4-489d-8cf3-932047cb25cd | cirros-0.3.4-x86_64-uec-kernel |
| 2ec0c911-0807-4eda-a70f-deb8ab192ad4 | cirros-0.3.4-x86_64-uec-ramdisk |
+--------------------------------------+---------------------------------+

However, that might change: https://review.openstack.org/#/c/338435/

We should change that pick_image method to just pick the first image it finds if it can't find the specific cirros-*uec image.

Matt Riedemann (mriedem)
Changed in python-novaclient:
status: New → Confirmed
importance: Undecided → Low
Matt Riedemann (mriedem)
tags: added: low-hanging-fruit
Ukesh (ukeshkumar)
Changed in python-novaclient:
assignee: nobody → Ukesh (ukeshkumar)
Ukesh (ukeshkumar)
Changed in python-novaclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/357845

Revision history for this message
Matt Riedemann (mriedem) wrote :

Since devstack is changing the default image from -uec to -disk.img this is actually going to be a critical fix for novaclient for the functional tests to pass:

https://review.openstack.org/#q,Id65ebae73b28da7185cb349b714b659af51ef77f,n,z

Changed in python-novaclient:
importance: Low → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/358189

Matt Riedemann (mriedem)
Changed in python-novaclient:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/357845
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=01de5a9f68ad474e9bfa213ffeb3501066a52ebd
Submitter: Jenkins
Branch: master

commit 01de5a9f68ad474e9bfa213ffeb3501066a52ebd
Author: Ukesh Kumar Vasudevan <email address hidden>
Date: Fri Aug 19 18:10:19 2016 +0530

    Pick first image if can't find the specific image

    In pick_image method to just pick the first image it finds
    if it can't find the specific cirros-*uec image.

    Also look for the -disk.img since devstack is changing
    the default image in:

    Id65ebae73b28da7185cb349b714b659af51ef77f

    Change-Id: I0e4c38a9e0ae25a922f6b0e09f3f2531f49c88c9
    Closes-Bug: 1614118

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/python-novaclient 6.0.0

This issue was fixed in the openstack/python-novaclient 6.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/python-novaclient 6.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (stable/mitaka)

Reviewed: https://review.openstack.org/358188
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=5bdee97f4843de36669e25aa27874c93451fe05a
Submitter: Jenkins
Branch: stable/mitaka

commit 5bdee97f4843de36669e25aa27874c93451fe05a
Author: Ukesh Kumar Vasudevan <email address hidden>
Date: Fri Aug 19 18:10:19 2016 +0530

    Pick first image if can't find the specific image

    In pick_image method to just pick the first image it finds
    if it can't find the specific cirros-*uec image.

    Also look for the -disk.img since devstack is changing
    the default image in:

    Id65ebae73b28da7185cb349b714b659af51ef77f

    Change-Id: I0e4c38a9e0ae25a922f6b0e09f3f2531f49c88c9
    Closes-Bug: 1614118
    (cherry picked from commit 01de5a9f68ad474e9bfa213ffeb3501066a52ebd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (stable/liberty)

Reviewed: https://review.openstack.org/358189
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=48a8e73b86c5d14b153e1246672a4520ea45ccaf
Submitter: Jenkins
Branch: stable/liberty

commit 48a8e73b86c5d14b153e1246672a4520ea45ccaf
Author: Ukesh Kumar Vasudevan <email address hidden>
Date: Fri Aug 19 18:10:19 2016 +0530

    Pick first image if can't find the specific image

    In pick_image method to just pick the first image it finds
    if it can't find the specific cirros-*uec image.

    Also look for the -disk.img since devstack is changing
    the default image in:

    Id65ebae73b28da7185cb349b714b659af51ef77f

    Change-Id: I0e4c38a9e0ae25a922f6b0e09f3f2531f49c88c9
    Closes-Bug: 1614118
    (cherry picked from commit 01de5a9f68ad474e9bfa213ffeb3501066a52ebd)
    (cherry picked from commit 5bdee97f4843de36669e25aa27874c93451fe05a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 6.0.0

This issue was fixed in the openstack/python-novaclient 6.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 2.30.3

This issue was fixed in the openstack/python-novaclient 2.30.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 6.0.0

This issue was fixed in the openstack/python-novaclient 6.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 3.3.3

This issue was fixed in the openstack/python-novaclient 3.3.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.