PEP8 python-novaclient cleanup

Bug #911552 reported by Zhongyue Luo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Zhongyue Luo

Bug Description

The None, True, and False values are singletons.

All variable *comparisons* to singletons should use 'is' or 'is not'.
All variable *evaluations* to boolean should use 'if' or 'if not'.
All Object type comparisons should use isinstance() instead of comparing types directly

Zhongyue Luo (zyluo)
tags: added: python-novaclient
summary: - PEP8 python-client cleanup
+ PEP8 python-novaclient cleanup
Changed in nova:
assignee: nobody → LZY (lzyeval)
Revision history for this message
Zhongyue Luo (zyluo) wrote :
Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/2772
Committed: http://github.com/openstack/python-novaclient/commit/4ff27703d077fc83bb715060a774faf4a15e9736
Submitter: Jenkins
Branch: master

commit 4ff27703d077fc83bb715060a774faf4a15e9736
Author: lzyeval <email address hidden>
Date: Wed Jan 4 09:54:39 2012 +0800

    PEP8 python-novaclient cleanup

    Fixes bug #911552

    The None, True, and False values are singletons.

    All variable *comparisons* to singletons should use 'is' or 'is not'.
    All variable *evaluations* to boolean should use 'if' or 'if not'.
    All Object type comparisons should use isinstance()
    instead of comparing types directly

    Change-Id: Ia5571e58e2662c652f0e996d8c1a1acb4531623d

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
affects: nova → python-novaclient
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.