Rebuild with user-data takes file path literally

Bug #1794419 reported by Sam Morrison on 2018-09-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Medium
Sam Morrison
Queens
Medium
Matt Riedemann
Rocky
Medium
Matt Riedemann

Bug Description

Using nova rebuild with the --user-data option just passes the path directly into user data.
It should read the contents of the file much like in the boot command

Fix proposed to branch: master
Review: https://review.openstack.org/605341

Changed in python-novaclient:
assignee: nobody → Sam Morrison (sorrison)
status: New → In Progress
Changed in python-novaclient:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/605341
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=cac7351b0ee9716f1be01e8711d6ed3a237362ca
Submitter: Zuul
Branch: master

commit cac7351b0ee9716f1be01e8711d6ed3a237362ca
Author: Sam Morrison <email address hidden>
Date: Wed Sep 26 16:47:53 2018 +1000

    Fix up userdata argument to rebuild.

    This was using the name of the file as user data as opposed
    to the content of the file.

    Change-Id: I9752d849aa0e6cf608db0def3ca89565cff4debc
    Closes-bug: #1794419

Changed in python-novaclient:
status: In Progress → Fix Released
Matt Riedemann (mriedem) wrote :

The bug was introduced in Queens so we should backport the fix.

https://review.openstack.org/#/c/528128/

This issue was fixed in the openstack/python-novaclient 11.1.0 release.

Reviewed: https://review.openstack.org/613057
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=5610ebd10d18ac6db204d31e8b4341a33a31e327
Submitter: Zuul
Branch: stable/rocky

commit 5610ebd10d18ac6db204d31e8b4341a33a31e327
Author: Sam Morrison <email address hidden>
Date: Wed Sep 26 16:47:53 2018 +1000

    Fix up userdata argument to rebuild.

    This was using the name of the file as user data as opposed
    to the content of the file.

    Change-Id: I9752d849aa0e6cf608db0def3ca89565cff4debc
    Closes-bug: #1794419
    (cherry picked from commit cac7351b0ee9716f1be01e8711d6ed3a237362ca)

Reviewed: https://review.openstack.org/613090
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=154b29b7a34ee3e1938574de2a69255b879979e5
Submitter: Zuul
Branch: stable/queens

commit 154b29b7a34ee3e1938574de2a69255b879979e5
Author: Sam Morrison <email address hidden>
Date: Wed Sep 26 16:47:53 2018 +1000

    Fix up userdata argument to rebuild.

    This was using the name of the file as user data as opposed
    to the content of the file.

    Change-Id: I9752d849aa0e6cf608db0def3ca89565cff4debc
    Closes-bug: #1794419
    (cherry picked from commit cac7351b0ee9716f1be01e8711d6ed3a237362ca)
    (cherry picked from commit 5610ebd10d18ac6db204d31e8b4341a33a31e327)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers