nova list filter "--instance-name" is no longer valid on the server side

[Surya Seetharaman]

As we can see from https://review.openstack.org/#/c/10917/, this option was removed on the server side long back, but its still on the client side https://github.com/openstack/python-novaclient/blob/c2d0fb7098a93390758d4d1f7c7c2cf4a7e38e3f/novaclient/v2/shell.py#L1377 which can be confusing for the users.

We should deprecate this option since its not important enough to be implemented on the server side.

[Tao Li (eric-litao)]

@Surya Seetharaman, I found you have reported this bug for a long time. If you haven't start it, may I fix it?

[Tao Li (eric-litao)]

This is my patch: https://review.openstack.org/#/c/602520/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/602520
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=910201f20157c57e8b24d1f0e82763250f6df0d7
Submitter: Zuul
Branch: master

commit 910201f20157c57e8b24d1f0e82763250f6df0d7
Author: Tao Li <[e-mail]>
Date: Fri Sep 14 11:09:38 2018 +0800

    Deprecate the unused instance-name

    The '--instnace-name' option exists in nova CLI for a long time,
    but it is not used, so we deprecate it firstly and will remove it in
    T release.

    Change-Id: I0c3d611fc322ae2c9f28ce3845b1c08eaab69485
    Closes-Bug: #1788182

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-novaclient 12.0.0 release.