novaclient.tests.unit.test_client.SessionClientTest.test_global_id fails

Bug #1697358 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Sean Dague

Bug Description

stack@devstack-master:/tmp/python-novaclient$ tox -e py27
(snipped...)
==============================
Failed 1 tests - output below:
==============================

novaclient.tests.unit.test_client.SessionClientTest.test_global_id
------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "novaclient/tests/unit/test_client.py", line 82, in test_global_id
        self.assertEqual(headers['X-OpenStack-Request-ID'], global_id)
      File "/tmp/python-novaclient/.tox/py27/local/lib/python2.7/site-packages/requests/structures.py", line 54, in __getitem__
        return self._store[key.lower()][1]
    KeyError: 'x-openstack-request-id'

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/473224

Changed in python-novaclient:
status: New → In Progress
tags: added: gate-failure testing
removed: test
Changed in python-novaclient:
assignee: Takashi NATSUME (natsume-takashi) → Sean Dague (sdague)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/473224
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=264c22a9cc0955a1d0f545d5bc5de30bdf7b5072
Submitter: Jenkins
Branch: master

commit 264c22a9cc0955a1d0f545d5bc5de30bdf7b5072
Author: Takashi NATSUME <email address hidden>
Date: Mon Jun 12 15:10:05 2017 +0900

    Fix setting 'global_request_id' in SessionClient

    In Ic75be3acb8b77aae8da631e3c4cd6f545a9a35cb,
    'global_request_id' is set
    in the constructor of class keystoneauth1.adaptor.Adapter.

    But 'global_request_id' was not passed to the constructor,
    'global_request_id' was cleared.
    It caused the test failure.

    It is not necessary to set 'global_request_id'
    in the constructor of class SessionClient
    and just passing 'global_request_id' in kwargs
    is required.

    Change-Id: Id587e35c221fe2b11889469f88557d254125ea7e
    Closes-Bug: #1697358

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 9.0.1

This issue was fixed in the openstack/python-novaclient 9.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.