Make method _console() public

Bug #1651677 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
huangtianhua

Bug Description

Now heat calls the individual methods to retrieve a console of a particular protocol, see https://github.com/openstack/heat/blob/master/heat/engine/clients/os/nova.py#L584-L617
it is not good in maintainability, so heat wants to use 'novaclient.v2.servers.ServerManager._console' method to simplify the implementation of retrieving server console. It's better to change this method to public for public use.
Also openstackclient can use the new unified interface to get console urls for server.

Tags: specless
Changed in python-novaclient:
assignee: nobody → huangtianhua (huangtianhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/414364

Changed in python-novaclient:
status: New → In Progress
tags: added: spec-lite
tags: added: specless
removed: spec-lite
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/414364
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=2512a28dc1f9a017b996c648ecd2551162ef1fc3
Submitter: Jenkins
Branch: master

commit 2512a28dc1f9a017b996c648ecd2551162ef1fc3
Author: huangtianhua <email address hidden>
Date: Thu Dec 22 10:31:29 2016 +0800

    Make _console() public

    Heat wants to use 'novaclient.v2.servers.
    ServerManager._console' method to simplify the
    implementation of retrieving server console.
    It's better to change the method to public for
    public use.
    The patch changes:
    1. add public method named get_console_url() for class
       'novaclient.v2.servers.Server'
    2. rename _console() to get_console_url() for class
       'novaclient.v2.servers.ServerManager'

    Change-Id: I3d1485468d1d0a79d4002981ebe05b6cdf2332e7
    Closes-Bug: #1651677

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 7.1.0

This issue was fixed in the openstack/python-novaclient 7.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.