test_trigger_crash_dump_in_locked_state_nonadmin failing since 8/30

[Matt Riedemann]

Seen here:

http://logs.openstack.org/18/353018/8/gate/gate-novaclient-dsvm-functional/72c5471/console.html

2016-08-30 15:53:36.465112 | 2016-08-30 15:53:36.464 | novaclient.tests.functional.v2.test_trigger_crash_dump.TestTriggerCrashDumpNovaClientV217.test_trigger_crash_dump_in_locked_state_nonadmin
2016-08-30 15:53:36.467798 | 2016-08-30 15:53:36.467 | ------------------------------------------------------------------------------------------------------------------------------------------
2016-08-30 15:53:36.468858 | 2016-08-30 15:53:36.468 |
2016-08-30 15:53:36.470332 | 2016-08-30 15:53:36.469 | Captured traceback:
2016-08-30 15:53:36.471440 | 2016-08-30 15:53:36.471 | ~~~~~~~~~~~~~~~~~~~
2016-08-30 15:53:36.472543 | 2016-08-30 15:53:36.472 | Traceback (most recent call last):
2016-08-30 15:53:36.474576 | 2016-08-30 15:53:36.474 | File "novaclient/tests/functional/v2/test_trigger_crash_dump.py", line 132, in test_trigger_crash_dump_in_locked_state_nonadmin
2016-08-30 15:53:36.475841 | 2016-08-30 15:53:36.475 | server_id, output)
2016-08-30 15:53:36.477014 | 2016-08-30 15:53:36.476 | File "/opt/stack/new/python-novaclient/.tox/functional/local/lib/python2.7/site-packages/testtools/testcase.py", line 417, in assertIn
2016-08-30 15:53:36.478688 | 2016-08-30 15:53:36.478 | self.assertThat(haystack, Contains(needle), message)
2016-08-30 15:53:36.480828 | 2016-08-30 15:53:36.479 | File "/opt/stack/new/python-novaclient/.tox/functional/local/lib/python2.7/site-packages/testtools/testcase.py", line 498, in assertThat
2016-08-30 15:53:36.481854 | 2016-08-30 15:53:36.481 | raise mismatch_error
2016-08-30 15:53:36.483026 | 2016-08-30 15:53:36.482 | testtools.matchers._impl.MismatchError: "ERROR (Conflict): Instance 388c7718-2f7c-4cd1-8335-0e72c78a3e7c is in an invalid state for 'trigger_crash_dump' (HTTP 409) " not in 'ERROR (Conflict): Instance 388c7718-2f7c-4cd1-8335-0e72c78a3e7c is locked (HTTP 409) (Request-ID: req-87433af1-7e63-4e7b-b154-d30286effa28)\n'

The error message on the nova-api side might have changed recently.

[Matt Riedemann (mriedem)]

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22testtools.matchers._impl.MismatchError%3A%20%5C%5C%5C%22ERROR%20(Conflict)%3A%20Instance%5C%22%20AND%20message%3A%5C%22is%20in%20an%20invalid%20state%20for%20'trigger_crash_dump'%20(HTTP%20409)%20%5C%5C%5C%22%20not%20in%20'ERROR%20(Conflict)%5C%22&from=7d

[Matt Riedemann (mriedem)]

This is the breaking change:

https://review.openstack.org/#/c/349450/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/363062

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/363062
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=c915a0267d5da2502edfb6639c9f21395b689a5a
Submitter: Jenkins
Branch: master

commit c915a0267d5da2502edfb6639c9f21395b689a5a
Author: Matt Riedemann <email address hidden>
Date: Tue Aug 30 13:33:02 2016 -0400

    Fix test_trigger_crash_dump_in_locked_state_nonadmin test

    Patch 2a70e9688151588347664badbac5d0a59ef0f95c in the server
    changed the error message that comes back in the case of a locked
    server which breaks this test. The test is unnecessarily rigid in
    it's assertion, we should just be checking that we get a 409
    back, not what the actual error message is, which is prone to change.

    Change-Id: I1fd64953e671c6c7fe1068a9c30f5a077712a9fb
    Closes-Bug: #1618561

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/python-novaclient 6.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-novaclient 6.0.0 release.