add version info for help on hypervisor-list

Bug #1616450 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Low
Takashi Natsume

Bug Description

jichen@refstack:~$ nova help hypervisor-list
usage: nova hypervisor-list [--matching <hostname>] [--marker <marker>]
                            [--limit <limit>]

List hypervisors. (Supported by API versions '2.0' - '2.latest') [hint: use
'--os-compute-api-version' flag to show help message for proper version]

Optional arguments:
  --matching <hostname> List hypervisors matching the given <hostname>. If
                         matching is used limit and marker options will be
                         ignored.
  --marker <marker> The last hypervisor of the previous page; displays
                         list of hypervisors after "marker".
  --limit <limit> Maximum number of hypervisors to display. If limit ==
                         -1, all hypervisors will be displayed. If limit is
                         bigger than 'osapi_max_limit' option of Nova API,
                         limit 'osapi_max_limit' will be used instead.

actually those params added from 2.33

jichenjc (jichenjc)
Changed in python-novaclient:
assignee: nobody → jichenjc (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/359838

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
jichenjc (jichenjc) wrote :

should be something like:

Optional arguments:
  --matching <hostname> List hypervisors matching the given <hostname>. If
                         matching is used limit and marker options will be
                         ignored. (Supported by API versions '2.33' -
                         '2.latest')

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-novaclient (master)

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/359838
Reason: This review is > 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Takashi Natsume (natsume-takashi) wrote :

IMO, it is not necessary to add the description in the help message output "nova help ...".
But the description should be added in the command reference.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/681174

Changed in python-novaclient:
assignee: jichenjc (jichenjc) → Takashi NATSUME (natsume-takashi)
Changed in python-novaclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.opendev.org/681174
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=730bc2c47ede9eca44b400f74540418765fcab66
Submitter: Zuul
Branch: master

commit 730bc2c47ede9eca44b400f74540418765fcab66
Author: Takashi NATSUME <email address hidden>
Date: Tue Sep 10 16:27:38 2019 +0900

    doc: Add support microversions for options

    Add descriptions of support microversions for the '--marker' option
    and the '--limit' option in the 'nova hypervisor-list' command
    in the CLI reference.

    Change-Id: Ie25e848b51fd0220e318393db123c97b4a642091
    Closes-Bug: #1616450

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 16.0.0

This issue was fixed in the openstack/python-novaclient 16.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.