nova flavor-access-list help is wrong, the API does not take a tenant_id

[Matt Riedemann]

The nova flavor-access-list command says it takes an optional --tenant-id to filter by tenant but the API doesn't actually support that.

CLI help: http://docs.openstack.org/cli-reference/nova.html#nova-flavor-access-list

API: https://github.com/openstack/nova/blob/67af54deb38d6a8e9c937e60de2deeecfcc2599e/nova/api/openstack/compute/flavor_access.py#L51

The CLI code actually fails if you try using --tenant without --flavor:

https://github.com/openstack/python-novaclient/blob/4.0.0/novaclient/v2/flavor_access.py#L44

We should just remove that --tenant option processing from the CLI.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/316969

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/316969
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=1fd68964ea33c9327ccd1bb566ea3ea8bffa725d
Submitter: Jenkins
Branch: master

commit 1fd68964ea33c9327ccd1bb566ea3ea8bffa725d
Author: Matt Riedemann <email address hidden>
Date: Mon May 16 12:08:48 2016 -0400

    Deprecate --tenant option from flavor-access-list

    The --tenant option in the flavor-access-list command was
    never implemented and filtering by tenant is not supported
    in the REST API for os-flavor-access, so to avoid confusion
    this change deprecates the command line option.

    It also removes the cruft that was in the python API code
    so that only 'flavor' is allowed. This it not a backward
    incompatible change since list() still takes kwargs and still
    raises a NotImplementedError for anything in kwargs but
    'flavor'.

    Change-Id: I2c36376674f3a7caf5967a16ac0152f17d9fc906
    Closes-Bug: #1582284

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-novaclient 4.1.0 release.