python-novaclient live_migrate args mismatch

[Sean M. Collins]

When attempting to use python-novaclient to do a host-evacuate-live - the following error is returned.

http://paste.openstack.org/show/491762/

Nova git commits are b55d5bc and 1feab8. Controller is b55d5bc and compute is 1feab8.

novaclient version is 3.3.0

No errors are reported in the traces on the controller or compute - which leads me to believe it's an error client side.

passing the --debug option yields the following

http://paste.openstack.org/show/491863/

Doing a little research, this commit looks suspicious.

https://github.com/openstack/python-novaclient/commit/ae598280acc46dd4ee20af78a5780a450f96b084

[Sean M. Collins (scollins)]

Pulling down python-novaclient 3.2.0 results in successful communication with the server. The migration is not successful, but that's because I don't have my DevStack environment configured correctly. So yes there appears to be a serious regression in the 3.3.0 tag of python-novaclient.

http://paste.openstack.org/show/491911/

I'll run a bisect to try and track down further.

[Sean M. Collins (scollins)]

Yep it was ae598280acc46dd4ee20af78a5780a450f96b084 that broke it.

[Matt Riedemann (mriedem)]

The workaround for now is to pass --os-compute-api-version=2.24 when running host-evacuate-live.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/297772

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/297774

[OpenStack Infra (hudson-openstack)]

Change abandoned by Andrey Kurilin (<email address hidden>) on branch: master
Review: https://review.openstack.org/297774
Reason: duplicate https://review.openstack.org/#/c/297772

[Matt Riedemann (mriedem)]

We should release the fix for newton in 3.4.0 and then we can backport to stable/mitaka and release as version 3.3.1.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/297772
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=90fbbb29562a905e8f70badf2c31cfb4ec6841ed
Submitter: Jenkins
Branch: master

commit 90fbbb29562a905e8f70badf2c31cfb4ec6841ed
Author: Matt Riedemann <email address hidden>
Date: Fri Mar 25 13:17:56 2016 -0400

    Fix host-evacuate-live for 2.25 microversion

    Change I01b22593724616bc0a7793c509ecabf095d6927d made the
    live_migrate() method in the ServerManager conditional on the
    API version requested. This broke the host-evacuate-live
    command which is calling ServerManager.live_migrate() directly
    with one too many arguments for the v2.25 version of the method.

    This updates the host-evacuate-live shell to behave like the
    live-migration method and be aware of the API version when
    calling the live_migrate() method.

    Related to blueprint making-live-migration-api-friendly

    Change-Id: I4dbeb6ebe03f03799b706be2d787d21484b5c664
    Closes-Bug: #1561938

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/298988

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/298988
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=b269aa4d7f40f259642474227e9258e982155f0d
Submitter: Jenkins
Branch: stable/mitaka

commit b269aa4d7f40f259642474227e9258e982155f0d
Author: Matt Riedemann <email address hidden>
Date: Fri Mar 25 13:17:56 2016 -0400

    Fix host-evacuate-live for 2.25 microversion

    Change I01b22593724616bc0a7793c509ecabf095d6927d made the
    live_migrate() method in the ServerManager conditional on the
    API version requested. This broke the host-evacuate-live
    command which is calling ServerManager.live_migrate() directly
    with one too many arguments for the v2.25 version of the method.

    This updates the host-evacuate-live shell to behave like the
    live-migration method and be aware of the API version when
    calling the live_migrate() method.

    Related to blueprint making-live-migration-api-friendly

    Conflicts:
            novaclient/v2/contrib/host_evacuate_live.py

    NOTE(mriedem): The conflict is due to
    93913c84b67d3aefe79bef106fbe9a83f0bcdb71 not being in stable/mitaka.
    Also note that this is not for a blueprint, it's just related
    to a blueprint that landed in mitaka but introduced a regression
    here when support was added for that blueprint with the 2.25
    microversion.

    Change-Id: I4dbeb6ebe03f03799b706be2d787d21484b5c664
    Closes-Bug: #1561938
    (cherry picked from commit 90fbbb29562a905e8f70badf2c31cfb4ec6841ed)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-novaclient 3.3.1 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/python-novaclient 3.4.0 release.