novaclient functional tests hardcoded assumptions about network setup

[Ralf Haferkamp]

Some of the functional tests for novaclient make assumptions about the network setup which should be avoided. E.g. the tests in
TestServersListNovaClient attaches instances to the first network returned by net-list. That only works if the first network returned is not an external network. Something similar is true for TestServersAPI which expects the default network to be called "private".

I guess it makes sense to allow to override that behaviour (by ENV?) to all running the functional tests against a setup that doesn't fulfill those requirements.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/239971

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239971
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=8a2ed13620e78f4b82e68028e86745e8c86240b0
Submitter: Jenkins
Branch: master

commit 8a2ed13620e78f4b82e68028e86745e8c86240b0
Author: Ralf Haferkamp <email address hidden>
Date: Wed Oct 28 15:33:22 2015 +0100

    Allow to specify a network for functional tests

    Currently the tests just attach instances to the first network returned
    by "net-list". That might however not be the right thing in some
    environments. This change allows to override the default network via the
    environment variable "OS_NOVACLIENT_NETWORK". If not specified the
    test will fallback to the old behaviour and just use the first network.

    Closes-Bug: #1510975
    Change-Id: Ie682111127584a33d8e96377d812d3a6352c760d

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-novaclient 3.3.0 release.