Unit tests failed with a new python-novaclient

[Ivan Kolodyazhny]

http://logs.openstack.org/86/239186/4/check/gate-cinder-python27/aec5afa/testr_results.html.gz

We'll fix it in a liberty with a patch to requirements. But we need to get better fix for Mitaka/master

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/239837

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239837
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=99dc6d34754954a27f6998406a94743c41b93981
Submitter: Jenkins
Branch: master

commit 99dc6d34754954a27f6998406a94743c41b93981
Author: Ivan Kolodyazhny <email address hidden>
Date: Wed Oct 28 07:45:57 2015 +0200

    Handle correct exception raised by python-novaclient

    We need to hanle both novaclient.exceptions.RequestTimeout
    and requests.Timeout to make it works with a different
    python-nocaclient versions.

    Change-Id: Ib58101f12c87653aef97e055d22542acbeeee4a7
    Closes-Bug: #1510790

[Matt Riedemann (mriedem)]

Revert proposed for novaclient here:

https://review.openstack.org/#/c/239941/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/239963

[Matt Riedemann (mriedem)]

I have a requirements series to block novaclient 2.33 from g-r on master and stable/liberty here:

https://review.openstack.org/#/q/I6e7657b60308b30eed89b269810c1f37cce43063,n,z

[OpenStack Infra (hudson-openstack)]

Change abandoned by Matt Riedemann (<email address hidden>) on branch: master
Review: https://review.openstack.org/239963
Reason: I think we should just revert. Duplicating all of the requests library exceptions in novaclient is a waste of time.

https://review.openstack.org/#/c/239941/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239941
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=63c7a576e194f48f0edb5a0b2d9c4f1d37516e74
Submitter: Jenkins
Branch: master

commit 63c7a576e194f48f0edb5a0b2d9c4f1d37516e74
Author: Matt Riedemann <email address hidden>
Date: Wed Oct 28 07:07:28 2015 -0700

    Revert "Do not expose exceptions from requests library"

    This reverts commit 2961e82bfa6e375ac3c17933fac532ed316ac976

    This broke cinder unit tests that have a timeout test for novaclient
    where they mock the requests library raising a Timeout exception. That
    test expects to get a requests Timeout passed through but with the
    change being reverted it was getting a RequestTimeout exception from
    novaclient, which breaks the test and fails the gate runs.

    We could change the cinder unit test to handle both the requests.Timeout
    and the new novaclient RequestTimeout, but that's just papering over
    the cinder failure, we wouldn't know what other clients are failing
    in the same way because they have code working around the requests
    exceptions getting passed through, so we should treat this like an API
    change.

    I'd be in favor of making the same change again iff the novaclient
    exceptions extended the requests exception types so it would be transparent
    to consumers, since novaclient.exceptions.RequestTimeout would be a
    requests.Timeout via inheritance. But given the gate breakage and it being
    summit week I'm inclined to revert first and think about a better long term
    fix later when people are back to discuss.

    Change-Id: I368728588e5997eef860a168539eb66c58f2e72a
    Closes-Bug: #1510790

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/240083

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240083
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=27e7ad0bd9f2cdf12d0617cb0e90d3788d8f8fbc
Submitter: Jenkins
Branch: master

commit 27e7ad0bd9f2cdf12d0617cb0e90d3788d8f8fbc
Author: Matt Riedemann <email address hidden>
Date: Wed Oct 28 17:00:46 2015 -0700

    Revert "Handle correct exception raised by python-novaclient"

    This reverts commit 99dc6d34754954a27f6998406a94743c41b93981

    With the block on novaclient 2.33 we can undo this workaround.
    The regression in novaclient was reverted and will be in the next
    release.

    Change-Id: If561b699eb04486660009f100c5db425c3586d3c
    Related-Bug: #1510790

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.