CLI "nova keypair-show", Positional arguments description error

Bug #1493212 reported by Xiaowei Qian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Low
Xiaowei Qian

Bug Description

CLI "nova keypair-show <Name or ID>", Positional arguments description supports ID , but does not actually support, So we need to modify the help information.

Reproduction:
[root]# nova help keypair-show
usage: nova keypair-show <keypair>

Show details about the given keypair.

Positional arguments:
  <keypair> Name or ID of keypair

[root]# nova keypair-show key-2
+-------------+-------------------------------------------------+
| Property | Value |
+-------------+-------------------------------------------------+
| created_at | 2015-09-01T02:38:15.000000 |
| deleted | False |
| deleted_at | - |
| fingerprint | b0:72:9e:89:03:aa:75:27:bc:98:12:9e:78:46:98:be |
| id | 631 |
| name | key-2 |
| updated_at | - |
| user_id | f20b321c214c46f897f33764e791722e |
+-------------+-------------------------------------------------+

[root]# nova keypair-show 631
ERROR (CommandError): No keypair with a name or ID of '631' exists.

Changed in python-novaclient:
assignee: nobody → Xiaowei Qian (xiaow-qian)
status: New → Confirmed
status: Confirmed → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221170

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-novaclient (master)

Change abandoned by Xiaowei Qian (<email address hidden>) on branch: master
Review: https://review.openstack.org/221170
Reason: error

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221181

melanie witt (melwitt)
Changed in python-novaclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/221181
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=f636481f015c380b610eb8c7e67571a3b4807c55
Submitter: Jenkins
Branch: master

commit f636481f015c380b610eb8c7e67571a3b4807c55
Author: Xiaowei Qian <email address hidden>
Date: Tue Sep 8 08:01:56 2015 +0000

    Modify "nova keypair-show" Positional arguments help information

    CLI "nova keypair-show <keypair>", Positional arguments:
      <keypair> Name or ID of keypair
    But in fact, it does not support ID,when using ID, the error is as follows:
    [root]# nova keypair-show 631
    ERROR (CommandError): No keypair with a name or ID of '631' exists.
    So it is needed to change the Positional arguments help information
    from "Name or ID of keypair" to "Name of keypair".

    Change-Id: I4cd022a6aa1ca937e7aeb33847dc3ce2d6d5690e
    Closes-Bug: #1493212
    Signed-off-by: Xiaowei Qian <email address hidden>

Changed in python-novaclient:
status: In Progress → Fix Committed
Changed in python-novaclient:
milestone: none → 2.30.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.