Backwards incompatible exception changes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-novaclient |
Fix Released
|
Critical
|
Andriy Kurilin |
Bug Description
The move to oslo exceptions in
https:/
has been done in a backwards incompatible way.
Heat is impacted by two issues in our tests, but I imagine many users may be surprised that the constructor ordering has changed.
- ClientException now inherits from Exception, and thus takes no constructor arguments, anywhere passing arguments will break.
- BadRequest constructor argument ordering has changes, so anywhere using positional arguments will break.
See: https:/
The main problem is that the gate is using the pypi version and that means we can't currently have tests which work with both the released and trunk version of novaclient. This is pretty inconvenient for devstack users running from trunk.
I'd also be interested to know if a proper analysis of the impact of this on novaclient itself has been performed, as it seems like there are at least a few areas where positional arguments are used, which may not work as expected now, e.g
https:/
Changed in python-novaclient: | |
assignee: | nobody → Andrey Kurilin (akurilin) |
Changed in python-novaclient: | |
status: | New → In Progress |
Partial-fix: https:/ /review. openstack. org/#/c/ 94166