Return incorrect message in keypair-show and keypair-delete

Bug #1307338 reported by ugvddm
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
ugvddm
python-novaclient
Fix Released
Undecided
ugvddm

Bug Description

Reproduce:
1.nova keypair-list

+----------+-------------------------------------------------+
| Name | Fingerprint |
+----------+-------------------------------------------------+
| root_key | 41:f3:fc:23:07:1d:99:cc:fd:e4:7a:a3:20:ba:78:25 |
+----------+-------------------------------------------------+

2.nova keypair-show root
ERROR: The resource could not be found. (HTTP 404) (Request-ID: req-542fa1da-0ab0-4624-b662-7d7c908508e2)

3.nova keypair-delete root
ERROR: The resource could not be found. (HTTP 404) (Request-ID: req-2f8587a3-ee5e-4134-ba5d-a2b3f0968cbc)

expected:
1.nova keypair-show root
ERROR: No keypair with a name or ID of 'root' exists.
2.nova keypair-delete root
ERROR: No keypair with a name or ID of 'root' exists.

Tags: api
ugvddm (271025598-9)
description: updated
Changed in nova:
assignee: nobody → ugvddm (271025598-9)
description: updated
ugvddm (271025598-9)
Changed in python-novaclient:
assignee: nobody → ugvddm (271025598-9)
ugvddm (271025598-9)
summary: - Return incorrect message in "keypair show"
+ Return incorrect message in keypair-show and keypair-delete
description: updated
description: updated
Tracy Jones (tjones-i)
tags: added: api
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/87828

Changed in nova:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88526

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/88526
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=fdd59e142a69d02123ad5b8522ba0e75c731e02f
Submitter: Jenkins
Branch: master

commit fdd59e142a69d02123ad5b8522ba0e75c731e02f
Author: Zhengguang <email address hidden>
Date: Fri Apr 18 15:15:48 2014 +0800

    Fix the incorrect return messages in keypair show and delete

    When we delete or show a keypair, if the keypair doesn't exist,
    we'll get "The resource could not be found.(HTTP 404)", this
    patch will change it to "ERROR: No keypair with a name or ID of
    'keypair_name' exists."

    Change-Id: Ifebd8d2213c327f3d3fdd672207170aebbe1bb40
    Closes-Bug: #1307338

Changed in python-novaclient:
status: In Progress → Fix Committed
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/87828
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6cd183a4bac7ae79bca380c960686ea33892f066
Submitter: Jenkins
Branch: master

commit 6cd183a4bac7ae79bca380c960686ea33892f066
Author: Zhengguang <email address hidden>
Date: Wed Apr 16 09:27:46 2014 +0800

    Fix the explanations of HTTPNotFound for keypair's API

    Gets the "explanation" from HTTPNotFound exception and returns
    correct message. the commit Ia784e09cda986a421e83c2820dfd0a2267867cdd
    has fixed this kind of bug already, but this bug is remained.

    Closes-Bug: #1307338
    Change-Id: I6811eecba86938e4253f437b7677cb7e4468fd67

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-1
status: Fix Committed → Fix Released
Michael Still (mikal)
Changed in python-novaclient:
milestone: none → 2.18.0
Michael Still (mikal)
Changed in python-novaclient:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.