py33: test_boot_files error

Bug #1235096 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Kui Shi

Bug Description

======================================================================
FAIL: novaclient.tests.v1_1.test_shell.ShellTest.test_boot_files
tags: worker-5
----------------------------------------------------------------------
Empty attachments:
  stderr

stdout: {{{
{'server': {'max_count': 1, 'name': 'some-server', 'flavorRef': '1', 'personality': [{'path': '/tmp/foo', 'contents'
: b'QkxBSAo='}, {'path': '/tmp/bar', 'contents': b'QkxBSAo='}], 'imageRef': '1', 'min_count': 1}}
!=
{'server': {'max_count': 1, 'name': 'some-server', 'flavorRef': '1', 'personality': [{'path': '/tmp/bar', 'contents'
: b'QkxBSAo='}, {'path': '/tmp/foo', 'contents': b'QkxBSAo='}], 'imageRef': '1', 'min_count': 1}}
}}}

Traceback (most recent call last):
  File "/opt/stack/python-novaclient-1004/novaclient/tests/v1_1/test_shell.py", line 536, in test_boot_files
    {'path': '/tmp/foo', 'contents': expected_file_data},
  File "/opt/stack/python-novaclient-1004/novaclient/tests/v1_1/test_shell.py", line 87, in assert_called_anytime
    return self.shell.cs.assert_called_anytime(method, url, body)
  File "/opt/stack/python-novaclient-1004/novaclient/tests/fakes.py", line 62, in assert_called_anytime
    assert entry[2] == body
AssertionError

Kui Shi (skuicloud)
Changed in python-novaclient:
assignee: nobody → Kui Shi (skuicloud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/49756

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/49756
Committed: http://github.com/openstack/python-novaclient/commit/f14273d1e07a6a7ffe49044d894a81cda48ed8ad
Submitter: Jenkins
Branch: master

commit f14273d1e07a6a7ffe49044d894a81cda48ed8ad
Author: Kui Shi <email address hidden>
Date: Fri Oct 4 08:08:44 2013 +0800

    py33: sort the files parameters of "--files"

    In Python 3.3, hash randomization is enabled by default. It causes the
    iteration order of dicts and sets to be unpredictable and differ across
    Python runs.

    Sort the files parameters when multiple files are designated.

    Close-Bug #1235096

    Change-Id: I0db645b3fb92408bd8c6780bfabe7ce8265a65a8

melanie witt (melwitt)
Changed in python-novaclient:
status: New → Fix Committed
Revision history for this message
melanie witt (melwitt) wrote :

novaclient 2.16.0 released on 2/26/2014

Changed in python-novaclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.