py33: test list migration error

Bug #1231871 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Kui Shi

Bug Description

FAIL: novaclient.tests.v1_1.contrib.test_migrations.MigrationsTest.test_list_migrations_with_filters
tags: worker-5
----------------------------------------------------------------------
Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
  File "/opt/stack/python-novaclient/novaclient/tests/v1_1/contrib/test_migrations.py", line 39, in test_list_migrations_with_filters
    '/os-migrations?status=finished&host=host1'
  File "/opt/stack/python-novaclient/novaclient/tests/fakes.py", line 36, in assert_called
    (expected + called)
AssertionError: Expected GET /os-migrations?status=finished&host=host1&cell_name=child1; got GET /os-migrations?cell_name=child1&host=host1&statu
s=finished

Kui Shi (skuicloud)
Changed in python-novaclient:
assignee: nobody → Kui Shi (skuicloud)
Kui Shi (skuicloud)
Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/48893

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/48893
Committed: http://github.com/openstack/python-novaclient/commit/ecdd79b04aa65b5e8740c5a2a5fdca2530f2d652
Submitter: Jenkins
Branch: master

commit ecdd79b04aa65b5e8740c5a2a5fdca2530f2d652
Author: Kui Shi <email address hidden>
Date: Sun Sep 29 21:45:36 2013 +0800

    py33: align the order of parameters for urlencode()

    In Python 3, hash randomization is enabled by default. It causes the
    iteration order of dicts and sets to be unpredictable and differ across
    Python runs.

    In the test case, the fixed expecting string will not match the test
    result, it is relying on the dict order.

    This change transforms the input dict to a sequence of two-element list,
    with fixed order, and update the related expecitng string.

    Close-Bug #1231871

    Change-Id: Ia998cdb6978fc024dd0d3c9bd161fbdebe68638a

Changed in python-novaclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.