Unable to use the flavor name in "nova flavor-access-add".

[fujioka yuuichi]

"nova flavor-access-add" and "nova flavor-access-remove" should be able to using the flavor name.

Conditions:
1. The flavor is non-public.
2. The tenant cannot access to the flavor.

Expect:

$ OS_TENANT_NAME=demo nova flavor-access-add foo d703a8a37a2f4c179eb030de0a406f88
+--------------------------------------+----------------------------------+
| Flavor_ID | Tenant_ID |
+--------------------------------------+----------------------------------+
| 633de033-023c-4a68-a98c-c8f30221918e | d703a8a37a2f4c179eb030de0a406f88 |
+--------------------------------------+----------------------------------+
$

Actual:

$ OS_TENANT_NAME=demo nova flavor-access-add foo d703a8a37a2f4c179eb030de0a406f88
ERROR: No flavor with a name or ID of 'foo' exists.
$

[Tiantian Gao (gtt116)]

I think it should belong to novaclient rather than nova. no?

[fujioka yuuichi (fujioka-yuuichi-d)]

Thank you for your comment.
I have removed nova from this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/39183

[Jun Xie (junxiebj)]

non-admin can not use 'nova flavor-access-add' to add private_flavor-id(or flavor_name), is this 'work as designed' or bug?

[fujioka yuuichi (fujioka-yuuichi-d)]

I think that is 'work as designed'.
Only admin can manage flavor. Non-admin can do only reference.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/39183
Committed: http://github.com/openstack/python-novaclient/commit/476e50f4d7f7c7f3231bca8beb194776c28b2267
Submitter: Jenkins
Branch: master

commit 476e50f4d7f7c7f3231bca8beb194776c28b2267
Author: Yuuichi Fujioka <email address hidden>
Date: Mon Jul 29 05:32:01 2013 +0900

    Allow name argument to flavor-access-add

    Administrator cannot use the flavor name in arguments of
    "nova flavor-access-add" and "nova flavor-access-remove"
    in following conditions.

    1. The flavor is non-public.
    2. The falvor doesn't belong administrator's tenant.

    This patch fixes this problem.

    Change-Id: Ic5e3222d0ff62667e003a61e6a94e85833da5d11
    Fixes: bug #1205298

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/44636

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/44636
Committed: http://github.com/openstack/python-novaclient/commit/97da33fcf599efeb29d7e496d34a450c78c557f5
Submitter: Jenkins
Branch: master

commit 97da33fcf599efeb29d7e496d34a450c78c557f5
Author: fujioka yuuichi <email address hidden>
Date: Mon Sep 2 11:03:50 2013 +0900

    Allow name argument to flavor-access-add

    Administrator cannot use the flavor name in arguments of
    "nova flavor-access-add" and "nova flavor-access-remove".

    This patch fixes this problem.

    Change-Id: I68b267dc071382f1978efc2088cd8e837455e8b4
    Related-Bug: #1205298

[melanie witt (melwitt)]

novaclient 2.16.0 released on 2/26/2014