tests.test_shell.ShellTest.test_password no longer passes

Bug #1166464 reported by Kevin L. Mitchell
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Critical
Kevin L. Mitchell

Bug Description

At some point, the "nova list" command started returning an empty table when no results were obtained, while the
tests.test_shell.ShellTest.test_password test was expecting a single newline. Whichever commit caused this change in behavior somehow made it past the gate without forcing the test to be updated.

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/26405

Changed in python-novaclient:
assignee: nobody → Kevin L. Mitchell (klmitch)
status: New → In Progress
Changed in python-novaclient:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/26405
Committed: http://github.com/openstack/python-novaclient/commit/69f9971da54b46a8883148e4cef6346c7933b6ec
Submitter: Jenkins
Branch: master

commit 69f9971da54b46a8883148e4cef6346c7933b6ec
Author: Kevin L. Mitchell <email address hidden>
Date: Mon Apr 8 16:38:07 2013 -0500

    Correct a unit test failure that crept into trunk

    At some point, the "nova list" command started returning an
    empty table when no results were obtained, while the
    tests.test_shell.ShellTest.test_password test was expecting
    a single newline. Whichever commit caused this change in
    behavior somehow made it past the gate without forcing the
    test to be updated.

    This commit fixes the issue by changing the output that
    test_shell.test_password is expecting.

    Fixes bug 1166464.

    Change-Id: I57636b4a1e525c440925caba0bbb51bbcd94b080

Changed in python-novaclient:
status: In Progress → Fix Committed
Revision history for this message
Dirk Mueller (dmllr) wrote :

This is actually a regression of PrettyTable 0.7.2, which changed default. I'll propose a revert that fixes the issue without breaking compatibility.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/27690

Changed in python-novaclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.