hasattr(requests, logging) -> 2nd argument should be a string

Bug #1122958 reported by Julie Pichon
44
This bug affects 6 people
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Undecided
Victoria Martinez de la Cruz

Bug Description

Horizon fails on a fresh devstack with the following error:

hasattr(): attribute name must be string

[...]
File "/opt/stack/horizon/openstack_dashboard/wsgi/../../openstack_dashboard/api/nova.py" in novaclient
  261. http_log_debug=settings.DEBUG)
File "/opt/stack/python-novaclient/novaclient/v1_1/client.py" in __init__
  146. cacert=cacert)
File "/opt/stack/python-novaclient/novaclient/client.py" in __init__
  103. if hasattr(requests, logging):

It should be hasattr(requests, "logging") on line 103.

Changed in python-novaclient:
assignee: nobody → Victoria Martínez de la Cruz (vickymsee)
Changed in python-novaclient:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21782

Changed in python-novaclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/21782
Committed: http://github.com/openstack/python-novaclient/commit/2b81789f1a86c4446aea20465cccbe08e3a820ae
Submitter: Jenkins
Branch: master

commit 2b81789f1a86c4446aea20465cccbe08e3a820ae
Author: Victoria Martínez de la Cruz <email address hidden>
Date: Tue Feb 12 11:46:02 2013 -0300

    Corrects 2nd argument type for logging

    Fixes a regression introduced in commit
    c73afa9fd1df14bff9186c1e73ac8f3593ef81db.

    This completely breaks Horizon in last
    DevStack version.

    Change-Id: Ib754c6ea325534399a34ff76a290475ac652fea9
    Fixes: bug #1122958

Changed in python-novaclient:
status: In Progress → Fix Committed
Changed in python-novaclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.