rxtx_factor should be validated as a float

Bug #1083651 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Medium
Dan Prince

Bug Description

rxtx_factor is stored in the Nova DB as a float... but novaclient requires it to be an integer:

[root@nova1 ~]# nova flavor-create --ephemeral 0 --swap 0 --rxtx-factor=1.0 foo 99 256 10 1
    ERROR: rxtx_factor must be an integer.

We should update our validations for flavor/create so that rxtx_factor can be a float.

Dan Prince (dan-prince)
Changed in python-novaclient:
importance: Undecided → Medium
assignee: nobody → Dan Prince (dan-prince)
status: New → Incomplete
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16979

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/16979
Committed: http://github.com/openstack/python-novaclient/commit/27d7ad9d8632bdc67e25757a42a91109e393fbf9
Submitter: Jenkins
Branch: master

commit 27d7ad9d8632bdc67e25757a42a91109e393fbf9
Author: Dan Prince <email address hidden>
Date: Tue Nov 27 10:59:43 2012 -0500

    Validate that rxtx_factor is a float.

    Nova stores rxtx_factor as a float internally and as such
    novaclient should validate that a float is specified
    when creating a flavor.

    Fixes LP Bug #1083651.

    Change-Id: I75f9440d3fe2a0e72ea592f2259640623400ae73

Changed in python-novaclient:
status: In Progress → Fix Committed
Changed in python-novaclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.