TypeError raised when attempting to get invalid image

[Brian Waldon]

When attempting to call novaclient.v1_1.client.images.get with a non-UUID image id, a TypeError is raised. python-novaclient should raise ImageNotFound instead:

>>> import novaclient.v1_1.client
>>> client = novaclient.v1_1.client.Client('demo', 'secrete', 'demo', 'http://192.168.27.100:5000/v2.0')
>>> client.images.get(name='name with spaces')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: get() got an unexpected keyword argument 'name'
>>> client.images.get('invalid id')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/bcwaldon/.virtualenvwrapper/openstack-clients/lib/python2.7/site-packages/novaclient/v1_1/images.py", line 38, in get
    return self._get("/images/%s" % base.getid(image), "image")
  File "/Users/bcwaldon/.virtualenvwrapper/openstack-clients/lib/python2.7/site-packages/novaclient/base.py", line 142, in _get
    return self.resource_class(self, body[response_key], loaded=True)
TypeError: string indices must be integers, not str

[Anita Kuno (anteaya)]

After a conversation with bcwaldon on irc, my current understanding of the solution to this bug derives from Brian's comment:
"what you want to assert is that a request for an image with a space in the image id translates to a similar string with a %20 in it".

So I will use this information as I move forward.

Thanks Brian,
Anita.

[Anita Kuno (anteaya)]

To result in an Image Not Found error, I need to assert %2D not %20.

[Anita Kuno (anteaya)]

Currently my understanding is that novaclient should be checking the format of the image argument, throwing an exception such as CommandError if the argument fails a format check.

With direction from bcwaldon I am currently trying to check the format in find_resource in utils.py.

[Anita Kuno (anteaya)]

After talking with Vishy on IRC, this bug is closed.