python-novaclient

setup.py build fails on Windows due to hardcoded paths

Bug #1052161 reported by Alessandro Pilotti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Medium
Alessandro Pilotti
Glance Client v0.6.0
neutron
Fix Released
Undecided
Alessandro Pilotti
neutron 2013.1 "grizzly"
oslo-incubator
Fix Released
Undecided
Yaguang Tang
oslo-incubator grizzly-1 "g1"
Grizzly
Fix Released
Undecided
Yaguang Tang
oslo-incubator 2013.1 "grizzly"
python-cinderclient
Fix Released
Undecided
Alessandro Pilotti
python-cinderclient 1.3.1 "1.3.1"
python-keystoneclient
Fix Released
High
Joseph Heck
python-keystoneclient 0.2.0
python-neutronclient
Fix Released
Medium
Alessandro Pilotti
python-neutronclient 2.2
python-novaclient
Fix Released
Undecided
Alessandro Pilotti
python-openstackclient
Fix Released
Undecided
Unassigned
python-swiftclient
Fix Released
Undecided
Alessandro Pilotti
python-swiftclient 2.5.0

Bug Description

python setup.py build fails on Windows due to the following hardcoded /bib/sh path in setup.py, line 120:

def _run_shell_command(cmd):
    output = subprocess.Popen(["/bin/sh", "-c", cmd],
                              stdout=subprocess.PIPE)

A possible solution consists in replacing "/bin/sh -c" with "cmd /C" when os.name == 'nt'

See original description
Alessandro Pilotti (alexpilotti)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13153

Changed in python-novaclient:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/13153
Committed: http://github.com/openstack/python-novaclient/commit/bfb0f70f40fdea6ee7b75dc2fb44baeadceb646d
Submitter: Jenkins
Branch: master

commit bfb0f70f40fdea6ee7b75dc2fb44baeadceb646d
Author: Alessandro Pilotti <email address hidden>
Date: Tue Sep 18 00:05:27 2012 +0300

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bib/sh

    Change-Id: I34f58ea09317c0be6ac23c5d9591bc83bc78782b

Changed in python-novaclient:
status: In Progress → Fix Committed
Joseph Heck (heckj)
Changed in python-keystoneclient:
status: New → Triaged
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13637

Changed in python-keystoneclient:
assignee: nobody → Joseph Heck (heckj)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/13637
Committed: http://github.com/openstack/python-keystoneclient/commit/818ab8e3cd024826ac0d0686ff7fa8243db7d4e8
Submitter: Jenkins
Branch: master

commit 818ab8e3cd024826ac0d0686ff7fa8243db7d4e8
Author: Joe Heck <email address hidden>
Date: Tue Sep 25 15:47:51 2012 +0000

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bin/sh

    Change-Id: I9b5838aa96d3f41f8baf58f28d3e9e6d9646f6cb

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15299

Changed in python-glanceclient:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15300

Changed in python-cinderclient:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15305

Yaguang Tang (heut2008)
Changed in openstack-common:
assignee: nobody → Yaguang Tang (heut2008)
status: New → In Progress
Changed in python-quantumclient:
assignee: nobody → Yaguang Tang (heut2008)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-quantumclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15330

Changed in python-quantumclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/15338

Changed in python-quantumclient:
assignee: Yaguang Tang (heut2008) → Alessandro Pilotti (alexpilotti)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-common (master)

Reviewed: https://review.openstack.org/15329
Committed: http://github.com/openstack/openstack-common/commit/18d138c1ec2d028981a64142d61d212c9fe8da52
Submitter: Jenkins
Branch: master

commit 18d138c1ec2d028981a64142d61d212c9fe8da52
Author: Yaguang Tang <email address hidden>
Date: Sat Nov 3 18:15:55 2012 +0800

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bib/sh.

    Change-Id: Iee0a1fcbdabfd469e92fa73002763d419e75ec27

Changed in openstack-common:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-quantumclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15389

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15401

Changed in python-novaclient:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-common (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/15481

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/15401
Committed: http://github.com/openstack/python-novaclient/commit/8be01b650e4669132c0d27481781bdf5688079ec
Submitter: Jenkins
Branch: master

commit 8be01b650e4669132c0d27481781bdf5688079ec
Author: Alessandro Pilotti <email address hidden>
Date: Mon Nov 5 17:47:05 2012 +0200

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bin/sh

    setup.py updated using openstack-common/update.py

    Change-Id: I9c8cf84ada189d8f27448ecda23f51c021d08818

Changed in python-novaclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-quantumclient (master)

Reviewed: https://review.openstack.org/15389
Committed: http://github.com/openstack/python-quantumclient/commit/6857c2ad69595d74fb5de90e1b00e9dabed50896
Submitter: Jenkins
Branch: master

commit 6857c2ad69595d74fb5de90e1b00e9dabed50896
Author: Alessandro Pilotti <email address hidden>
Date: Sat Nov 3 21:40:50 2012 +0200

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bin/sh

    setup.py updated using openstack-common/update.py

    Change-Id: I3943725a1f4b067a06f8f850e993c6867399a967

Changed in python-quantumclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/15301
Committed: http://github.com/openstack/python-openstackclient/commit/67e413a224d8bec7729ec1aa703c6e4c91ee243b
Submitter: Jenkins
Branch: master

commit 67e413a224d8bec7729ec1aa703c6e4c91ee243b
Author: Alessandro Pilotti <email address hidden>
Date: Mon Nov 5 18:34:15 2012 +0200

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bin/sh

    setup.py updated using openstack-common/update.py

    Change-Id: I33d38e0f96b6d124248c4a31959952d61cf1eb16

Changed in python-openstackclient:
status: New → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/15305
Committed: http://github.com/openstack/python-glanceclient/commit/16aafa728e4b8309b16bcc120b10bc20372883f4
Submitter: Jenkins
Branch: master

commit 16aafa728e4b8309b16bcc120b10bc20372883f4
Author: Alessandro Pilotti <email address hidden>
Date: Mon Nov 5 18:19:13 2012 +0200

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bin/sh

    setup.py updated using openstack-common/update.py

    Change-Id: If0ae835aeada8769e46dddf4f3c2f2edfdfbc5fe

Changed in python-glanceclient:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
affects: openstack-common → oslo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-swiftclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/15517

Changed in python-swiftclient:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/15300
Committed: http://github.com/openstack/python-cinderclient/commit/1abc0b4edfa70485cd32bac2060b1b223850752e
Submitter: Jenkins
Branch: master

commit 1abc0b4edfa70485cd32bac2060b1b223850752e
Author: Alessandro Pilotti <email address hidden>
Date: Tue Nov 6 19:38:28 2012 +0200

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bin/sh

    setup.py updated using openstack-common/update.py

    Change-Id: Iafae444a43c76560020a84e3a1c5c8cb4b6860da

Changed in python-cinderclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-swiftclient (master)

Reviewed: https://review.openstack.org/15517
Committed: http://github.com/openstack/python-swiftclient/commit/72531338377e296f30dee626bd6df171ba713b8a
Submitter: Jenkins
Branch: master

commit 72531338377e296f30dee626bd6df171ba713b8a
Author: Alessandro Pilotti <email address hidden>
Date: Tue Nov 6 20:08:11 2012 +0200

    Fixes setup compatibility issue on Windows

    Fixes Bug #1052161

    "python setup.py build" fails on Windows due to a hardcoded shell path:
    /bin/sh

    setup.py updated using openstack-common/update.py

    Change-Id: I763dd5613d91a2523087173b196500648c477fa6

Changed in python-swiftclient:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon)
Changed in python-glanceclient:
importance: Undecided → Medium
Brian Waldon (bcwaldon)
Changed in python-glanceclient:
milestone: none → v0.6.0
status: Fix Committed → Fix Released
Mark McLoughlin (markmc)
Changed in oslo:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19061

Changed in quantum:
assignee: nobody → Alessandro Pilotti (alexpilotti)
status: New → In Progress
Dean Troyer (dtroyer)
Changed in python-openstackclient:
status: Fix Committed → Fix Released
Revision history for this message
Mark McClain (markmcclain) wrote :

Quantum has updated it's version of openstack.common in another changeset which addresses this issue.

Changed in quantum:
status: In Progress → Fix Committed
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Quantum update is the following. (just for note)

commit de99585d4feef9c73020a8b1c53fb719f604556a
Author: Gary Kotton <email address hidden>
Date: Mon Jan 7 13:52:21 2013 +0000

    Latest OSLO updates

    Change-Id: Ibf223203c8b34f614357fa4539d0dfa953765d6b

Changed in quantum:
milestone: none → grizzly-3
Changed in python-quantumclient:
milestone: none → 3.0.0
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
yong sheng gong (gongysh)
Changed in python-quantumclient:
milestone: 3.0.0 → 2.2
Akihiro Motoki (amotoki)
Changed in python-quantumclient:
importance: Undecided → Medium
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-3 → 2013.1
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.2.0
status: Fix Committed → Fix Released
Russell Bryant (russellb)
Changed in python-novaclient:
status: Fix Committed → Fix Released
Doug Hellmann (doug-hellmann)
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
Doug Hellmann (doug-hellmann)
Changed in python-swiftclient:
milestone: none → 2.5.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.