reversed parent,obj parameters in extension code

[Thomas Morin]

The code handling extension of the Neutron client is not self consistent in the case where parent_id/parent_resource is used.

This makes it impossible, I think, to write an extension with parent_id/parent_resource.

The code in neutronclient/neutron/v2_0/__init__.py always has the parent id as first parameter, and if any, the object id as a second parameter:

python-neutronclient% grep 'def _parent_fx' neutronclient/v2_0/client.py
        def _parent_fx(parent_id, obj, **_params):
        def _parent_fx(parent_id, **_params):
        def _parent_fx(parent_id, body=None):
        def _parent_fx(parent_id, obj):
        def _parent_fx(parent_id, obj, body=None):

The code calling these function, in neutronclient/neutron/v2_0/__init__.py, do not always pass parent_id as first parameter:

python-neutronclient% grep obj_.*parent neutronclient/neutron/v2_0/__init__.py
            data = obj_lister(parent_id, **params)
        data = obj_lister(parent_id, **params)
            data = obj_creator(self.parent_id, body)
            obj_updater(_id, self.parent_id, body)
            obj_deleter(_id, self.parent_id)
            data = obj_lister(self.parent_id, **search_opts)
            data = obj_shower(_id, self.parent_id, **params)

The problematic calls are:
            obj_updater(_id, self.parent_id, body)
            obj_deleter(_id, self.parent_id)
            data = obj_shower(_id, self.parent_id, **params)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/233571

[Thomas Morin (tmmorin-orange)]

We hit the bug in networking-bgpvpn, making it impossible to create the API sub-resources we define server-side.
The impact is thus high on that project

Fixing this in liberty 1 release of python-neutronclient would allow the networking-bgpvpn to not have a less optimal requirement on a later release of python-neutronclient.

Could we fasttrack the fix and a backport in liberty ?

[Ihar Hrachyshka (ihar-hrachyshka)]

The bug is already marked for L consideration, but it won't happen before the patch is merged in master.

[Ryan Moats (rmoats)]

Ihar is correct - we have to merge the patch in master first

[Thomas Morin (tmmorin-orange)]

Ok, so the next step is reviewing the proposed change.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/233571
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=1ced38c1a72271faabb7ef6d3b37d3f7d329ac4f
Submitter: Jenkins
Branch: master

commit 1ced38c1a72271faabb7ef6d3b37d3f7d329ac4f
Author: Thomas Morin <email address hidden>
Date: Mon Oct 12 12:18:55 2015 +0200

    Revert parent_id and obj_id parameter order

    This change reverts the parameter order between parent_id and
    object id in the definition of obj_updater, obj_deleter, and obj_shower
    in neutronclient/v2_0/client.py, to match the call order in
    neutronclient/neutron/v2_0/__init__.py .

    Fixing the caller code would be the alternative, but would require
    changing the sig of many non-dynmically created methods in
    neutronclient/v2_0/client.py .

    Change-Id: Ia5d499e5a3cf3ff1b357c954f7e82a9066c94982
    Closes-Bug: 1505170

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/235140

[Thomas Morin (tmmorin-orange)]

Do we have a chance to have the fix in the 3.2.0 python-neutronclient release ?

[Ihar Hrachyshka (ihar-hrachyshka)]

It will of course be included in 3.2.0 (a release from Mitaka), and if backported, in 3.1.1 (next Liberty release).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Thomas Morin (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/235140

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/235827

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235827
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=05908356a7c6828ec26b399e45387a12a6d5cec7
Submitter: Jenkins
Branch: stable/liberty

commit 05908356a7c6828ec26b399e45387a12a6d5cec7
Author: Thomas Morin <email address hidden>
Date: Mon Oct 12 12:18:55 2015 +0200

    Revert parent_id and obj_id parameter order

    This change reverts the parameter order between parent_id and
    object id in the definition of obj_updater, obj_deleter, and obj_shower
    in neutronclient/v2_0/client.py, to match the call order in
    neutronclient/neutron/v2_0/__init__.py .

    Fixing the caller code would be the alternative, but would require
    changing the sig of many non-dynmically created methods in
    neutronclient/v2_0/client.py .

    Change-Id: Ia5d499e5a3cf3ff1b357c954f7e82a9066c94982
    Closes-Bug: 1505170
    (cherry picked from commit 1ced38c1a72271faabb7ef6d3b37d3f7d329ac4f)

[Thomas Morin (tmmorin-orange)]

Would it be possible to consider releasing a stable/liberty revision including this patch ?

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-neutronclient 4.0.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-neutronclient 3.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-neutronclient 3.1.1 release.