python34 neutronclient job is broken with unicodecsv 0.14.1

Bug #1499004 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Critical
Henry Gessau
Liberty
Fix Released
Undecided
Unassigned
Kyle Mestery (mestery)
Changed in python-neutronclient:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/226891

Changed in python-neutronclient:
assignee: nobody → Henry Gessau (gessau)
status: Confirmed → In Progress
Akihiro Motoki (amotoki)
tags: added: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/226891
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=fcf289797c063088f9003359dfd1c7d4f41ed5ef
Submitter: Jenkins
Branch: master

commit fcf289797c063088f9003359dfd1c7d4f41ed5ef
Author: Henry Gessau <email address hidden>
Date: Wed Sep 23 13:31:50 2015 -0400

    Py3k compliance: check for bytes when making a string

    When faking stdout in tests we must account for the case when
    "strings" might be bytes, which python3 cares about.

    Change-Id: I0e9349c86371055eed479799d39ab6adbcad6f95
    Closes-Bug: #1499004

Changed in python-neutronclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/227185

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (stable/liberty)

Reviewed: https://review.openstack.org/227185
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=db7eb557403da7c0e1eca7e12f6ddab6bc0d1fc1
Submitter: Jenkins
Branch: stable/liberty

commit db7eb557403da7c0e1eca7e12f6ddab6bc0d1fc1
Author: Henry Gessau <email address hidden>
Date: Wed Sep 23 13:31:50 2015 -0400

    Py3k compliance: check for bytes when making a string

    When faking stdout in tests we must account for the case when
    "strings" might be bytes, which python3 cares about.

    Change-Id: I0e9349c86371055eed479799d39ab6adbcad6f95
    Closes-Bug: #1499004
    (cherry picked from commit fcf289797c063088f9003359dfd1c7d4f41ed5ef)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/231700
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=88eb5845b77fa06a12c096706093329f82dba54c
Submitter: Jenkins
Branch: master

commit 88eb5845b77fa06a12c096706093329f82dba54c
Author: Cedric Brandily <email address hidden>
Date: Tue Oct 6 22:22:09 2015 +0200

    Ensure to decode bytes or fail

    The commit fcf289797c063088f9003359dfd1c7d4f41ed5ef introduces the
    pattern:

      if isinstance(line, bytes):
        try:
          line = line.decode(encoding='utf-8')
        except UnicodeError:
          pass
      # concat line with a string

    which is not working in PY3K if an UnicodeError is raised because line
    is not decoded and concatened to a string.

    This change delegates decoding to safe_decode[1] which returns a text
    object or raises an error.

    [1] oslo_utils.encodeutils

    Closes-Bug: #1503415
    Related-Bug: #1499004
    Change-Id: I16b8013f33aa3efad65be8040d3210120e047bbd

Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: none → 4.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-neutronclient (stable/liberty)

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/252876

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-neutronclient (stable/liberty)

Reviewed: https://review.openstack.org/252876
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=c5e1d2b827e16b761aa9601355fc91d969527d73
Submitter: Jenkins
Branch: stable/liberty

commit c5e1d2b827e16b761aa9601355fc91d969527d73
Author: Cedric Brandily <email address hidden>
Date: Tue Oct 6 22:22:09 2015 +0200

    Ensure to decode bytes or fail

    The commit fcf289797c063088f9003359dfd1c7d4f41ed5ef introduces the
    pattern:

      if isinstance(line, bytes):
        try:
          line = line.decode(encoding='utf-8')
        except UnicodeError:
          pass
      # concat line with a string

    which is not working in PY3K if an UnicodeError is raised because line
    is not decoded and concatened to a string.

    This change delegates decoding to safe_decode[1] which returns a text
    object or raises an error.

    [1] oslo_utils.encodeutils

    Closes-Bug: #1503415
    Related-Bug: #1499004
    Change-Id: I16b8013f33aa3efad65be8040d3210120e047bbd
    (cherry picked from commit 88eb5845b77fa06a12c096706093329f82dba54c)

Akihiro Motoki (amotoki)
tags: removed: liberty-backport-potential
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-neutronclient 4.0.0

This issue was fixed in the openstack/python-neutronclient 4.0.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-neutronclient 3.1.1

This issue was fixed in the openstack/python-neutronclient 3.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/python-neutronclient 3.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.