neutronclient broken because of oslo.i18n 2.0.0 release

Bug #1469087 reported by Emmanuel Cazenave
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-neutronclient
Invalid
Undecided
Ihar Hrachyshka
2.3
Fix Released
High
Kyle Mestery
Kilo
Invalid
Undecided
Unassigned

Bug Description

oslo 2.0.0 got away from the global 'oslo' namespace.

This produces these kind of errors, with python-neutronclient 2.3.10 in my case :

 File "/usr/local/lib/python2.7/dist-packages/neutronclient/common/exceptions.py", line 16, in <module>
from neutronclient.i18n import _
File "/usr/local/lib/python2.7/dist-packages/neutronclient/i18n.py", line 13, in <module>
 from oslo import i18n
ImportError: cannot import name i18n

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

It's fixed in 2.6.0. As for older versions, they are not supposed to be used with this version of oslo.i18n. In requirements.txt, stable/kilo has: oslo.i18n>=1.5.0,<1.6.0

Changed in python-neutronclient:
assignee: nobody → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

So use 2.4.0 or later to avoid fetching the new oslo.i18n.

Changed in python-neutronclient:
status: New → Invalid
Revision history for this message
Adam Gandelman (gandelman-a) wrote :

I believe this is actually an issue for stable/branches and, by extension, python-neutronclient>=2.3.6,<2.4.0 (juno) and python-neutronclient>=2.3.11,<2.5.0 (kilo)

I believe we need releases within those ranges that limit oslo.i18n to the respective stable branches' g-r constraint.

Revision history for this message
Kyle Mestery (mestery) wrote :

Do we really need a new release to fix this? Ihar's comments make it unclear to me. Lets resolve this before I work with the release team to do the actual release.

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

So its fine for stable/kilo:

 * stable/kilo g-r:
    - python-neutronclient>=2.3.11,<2.5.0
    - oslo.i18n>=1.5.0,<1.6.0 # Apache-2.0

  * python-neutronclient 2.4.0 (stable/kilo's most recent available version):
    - oslo.i18n>=1.5.0,<1.6.0 # Apache-2.0

However, stable/juno it's an issue.:

 * stable/juno g-r:
   - python-neutronclient>=2.3.6,<2.4.0
   - oslo.i18n>=1.0.0,<=1.3.1 # Apache-2.0

 * python-neutronclient 2.3.11 (stable/kilo's most recent available verison):
   - oslo.i18n>=1.3.0 # Apache-2.0

This means juno things will end up with python-neutronclient 2.3.11 which pulls in the newest oslo.i18n that includes the removal of the namespace package.

Revision history for this message
Ihar Hrachyshka (ihar-hrachyshka) wrote :

Indeed that's the case. But afaik we don't have a Juno branch for the neutron client to release 2.3.11.1 from. What should we do in that case? Do we need a Juno branch now?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/204651

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-neutronclient (stable/juno)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/204651
Reason: Abandoning in favor of https://review.openstack.org/#/c/204654/.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (stable/juno)

Reviewed: https://review.openstack.org/204654
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=3f03a3bdb87782930eaf236f726f9bed7229e441
Submitter: Jenkins
Branch: stable/juno

commit 3f03a3bdb87782930eaf236f726f9bed7229e441
Author: Doug Hellmann <email address hidden>
Date: Wed Jul 22 14:46:18 2015 +0000

    requirements: Cap requirements for juno

    Change-Id: If4ac5cc3ed9dc3a514a14efd49ba8f9a886a1f9c
    Closes-Bug: #1469087
    Depends-On: I19ede488c053235b3e2d7c66818c27440a650f9d
    Co-Authored-By: Kyle Mestery <email address hidden>
    Signed-off-by: Kyle Mestery <email address hidden>

tags: added: in-stable-juno
Revision history for this message
Matt Riedemann (mriedem) wrote :

This has totally broken stable/kilo, see bug 1482758.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.