Exceptions in quantumclient are inconsistently defined

Bug #987586 reported by Maru Newby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Low
Unassigned
neutron
Invalid
Low
yong sheng gong
python-neutronclient
Invalid
Medium
Unassigned

Bug Description

As per the suggestions in the following review:

https://review.openstack.org/#/c/6450/1/quantumclient/common/exceptions.py

 - Merge QuantumClientException with QuantumException
 - Ensure that all exceptions define a default message
 - Remove the 'Client' qualifier from the name of all exceptions

Revision history for this message
dan wendlandt (danwent) wrote :

Yong, can you comment on whether this still matters with the new version of the client? If so, we can keep it, otherwise, please mark as invalid.

Changed in quantum:
status: New → Invalid
status: Invalid → Confirmed
importance: Undecided → Low
assignee: nobody → yong sheng gong (gongysh)
Revision history for this message
yong sheng gong (gongysh) wrote :

Yes. we can keep it.

Changed in quantum:
status: Confirmed → Invalid
Changed in python-quantumclient:
assignee: nobody → Roman Podolyaka (rpodolyaka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-quantumclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24333

Changed in python-quantumclient:
status: New → In Progress
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

Changing of exceptions names in quantumclient breaks corresponding imports in Horizon. So we should update both projects.

Changed in horizon:
assignee: nobody → Roman Podolyaka (rpodolyaka)
Revision history for this message
Mark McClain (markmcclain) wrote :

I'd hold off on making these changes. The 3.0.0 version is a significant change and we should update Horizon once.

Changed in python-quantumclient:
importance: Undecided → Medium
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

Sure. Should this bug be attached to milestone 3.0.0?

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
milestone: none → havana-1
Changed in horizon:
milestone: havana-1 → havana-2
Changed in horizon:
milestone: havana-2 → havana-3
Changed in horizon:
milestone: havana-3 → none
Changed in python-neutronclient:
assignee: Roman Podoliaka (rpodolyaka) → nobody
status: In Progress → Confirmed
Timur Sufiev (tsufiev-x)
Changed in horizon:
assignee: Roman Podoliaka (rpodolyaka) → nobody
Revision history for this message
Akihiro Motoki (amotoki) wrote :

It was superceded by bug 1296148 which was released.

Changed in horizon:
status: Confirmed → Invalid
Changed in python-neutronclient:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.