Wrong description for function list_networks_on_dhcp_agent

Bug #1802472 reported by ChenjieXu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Low
ChenjieXu

Bug Description

For function list_networks_on_dhcp_agent in the python-neutronclient\neutronclient\v2_0\client.py, the description is "Fetches a list of dhcp agents hosting a network". However this function fetches a list of networks hosted on a DHCP agent.

ChenjieXu (midone)
Changed in python-neutronclient:
assignee: nobody → ChenjieXu (midone)
Revision history for this message
Slawek Kaplonski (slaweq) wrote :

Are You talking about docstring in method: https://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L1497 ? If so and if You think it's worth to fix, please at least push one patch to close this issue and https://bugs.launchpad.net/python-neutronclient/+bug/1802475 :)

Changed in python-neutronclient:
importance: Undecided → Low
tags: added: low-hanging-fruit
Revision history for this message
ChenjieXu (midone) wrote :

Hi Slawek, thanks for your comment. Yes, I'm talking about that line and I will fix that.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/617228

Changed in python-neutronclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/617228
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=cb1e24b1784fdee751a21d2b793b584538fefe58
Submitter: Zuul
Branch: master

commit cb1e24b1784fdee751a21d2b793b584538fefe58
Author: mid_one <email address hidden>
Date: Mon Nov 12 23:41:39 2018 +0800

    Fix docstring in method list_networks_on_dhcp_agent

    For function list_networks_on_dhcp_agent in the
    python-neutronclient\neutronclient\v2_0\client.py,
    the description is "Fetches a list of dhcp agents
    hosting a network". However this function fetches
    a list of networks hosted on a DHCP agent.

    Change the docstring.

    Change-Id: Ifa833d9a7ecab8ba55283d41d7a336d20cb578c3
    Closes-Bug: 1802472

Changed in python-neutronclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-neutronclient 6.11.0

This issue was fixed in the openstack/python-neutronclient 6.11.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.