networking-sfc: cannot set a flow classifier on an existing port chain

Bug #1716942 reported by Bernard Cafarelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Undecided
Bernard Cafarelli

Bug Description

Tested on current master, but Pike probably has the bug too:
$ openstack sfc port chain set --flow-classifier FC_udp PC1
'Client' object has no attribute 'list_sfc_flow_classifiers'

"set --no-flow-classifier" works fine though

And old CLI works:
neutron port-chain-update --flow-classifier FC_http PC1

Revision history for this message
Bernard Cafarelli (bcafarel) wrote :

All the find_resource() calls for SFC may actually have a problem, the list command is expected to be plural and with a sfc_ prefix.

Looking into it

Changed in python-neutronclient:
assignee: nobody → Bernard Cafarelli (bcafarel)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/504060

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-neutronclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/512577

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/512577
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=0907ccc4df68c71f1af71976819bff741829e434
Submitter: Zuul
Branch: master

commit 0907ccc4df68c71f1af71976819bff741829e434
Author: Bernard Cafarelli <email address hidden>
Date: Tue Oct 17 12:14:59 2017 +0200

    SFC plugin: fix all list commands

    Rename all list_ functions to follow the expected naming format
    expected by find_resource() calls: "list_%s" % cmd_resource_plural

    Rename for consistency the other SFC commands to include the "_sfc_"
    prefix

    Change-Id: Ie01692d5cbe928b042c7e8052295a781ac205764
    Related-Bug: #1716942

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/504060
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=864f4d111f325dd7458ada523fbc3355d3afce2f
Submitter: Zuul
Branch: master

commit 864f4d111f325dd7458ada523fbc3355d3afce2f
Author: Bernard Cafarelli <email address hidden>
Date: Tue Oct 17 12:18:18 2017 +0200

    SFC plugin: fix port chain set commands

    Setting a flow classifier or port pair group currently fails,
    additionally with multiple flow classifiers only the last one is added

    * Fix adding multiple items in the same command
    * Update unit test to try setting multiple flow classifiers

    Change-Id: Ifbc24d84022c9893d3348fb27b20206fa464d8b2
    Closes-Bug: #1716942

Changed in python-neutronclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-neutronclient 6.6.0

This issue was fixed in the openstack/python-neutronclient 6.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.