test_commands_dict_populated occasionally fails due to AttributeError

[Akihiro Motoki]

http://logs.openstack.org/42/487842/7/check/gate-python-neutronclient-python27-ubuntu-xenial/8c08d5d/console.html

http://paste.openstack.org/show/617942/

[Akihiro Motoki (amotoki)]

The reliable way to reproduce this with 100% is to run neutronclient.tests.unit.test_shell.ShellTest.test_commands_dict_populated only, so the cause looks like that neutronclient.shell.COMMANDS is not defined explicitly until NeutronShell class is instantiated.

[Akihiro Motoki (amotoki)]

the latest stable/pike commit (commit f9bac295420cbaacdb081786f96647840f8f3742) hits this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/492175

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/492175
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=4c3fbe2639664c25d3c06522f9c85713e65bb893
Submitter: Jenkins
Branch: master

commit 4c3fbe2639664c25d3c06522f9c85713e65bb893
Author: Akihiro Motoki <email address hidden>
Date: Wed Aug 9 15:23:54 2017 +0000

    Define shell.COMMANDS explicitly to avoid random UT failure

    Mocking non-existing attribute causes UT faillure.
    As a result, neutronclient UT fails depending on
    executing order of tests.

    Change-Id: Id047527fba9e908938f7157781fb0e36e76011c7
    Closes-Bug: #1709652

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/493332

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493332
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=a0893c32c7929fa5b3fb7c3b08820baeed3023b3
Submitter: Jenkins
Branch: stable/pike

commit a0893c32c7929fa5b3fb7c3b08820baeed3023b3
Author: Akihiro Motoki <email address hidden>
Date: Wed Aug 9 15:23:54 2017 +0000

    Define shell.COMMANDS explicitly to avoid random UT failure

    Mocking non-existing attribute causes UT failure.
    As a result, neutronclient UT fails depending on
    executing order of tests.

    Change-Id: Id047527fba9e908938f7157781fb0e36e76011c7
    Closes-Bug: #1709652
    (cherry picked from commit 4c3fbe2639664c25d3c06522f9c85713e65bb893)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-neutronclient 6.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-neutronclient 6.5.1 release.