OSC trunk set gives unhelpful errors

[IWAMOTO Toshihiro]

When adding a subport to a trunk, segmentation-type and segmentation-id must be specified.
In a command line, they must use hyphens not underscores, but the error message gives no clue on that.

$ openstack network trunk set --subport port=3ab45507-1f96-43ca-a00f-57aad15e5ec1,segmentation_id=101,segmentation-type=vlan trunk
Failed to add subports to trunk 'trunk': Invalid input for operation: Invalid subport details '{u'segmentation_type': u'vlan', u'port_id': u'3ab45507-1f96-43ca-a00f-57aad15e5ec1'}': missing segmentation information. Must specify both segmentation_id and segmentation_type.
Neutron server returns request_ids: ['req-2f6e5a47-be4d-48fe-ae4b-af68a5028228']

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/373847

[Armando Migliaccio (armando-migliaccio)]

The help tells you the syntax to use.

usage: openstack network trunk set [-h] [--name <name>]
                                   [--subport <port=,segmentation-type=,segmentation-id=>]
                                   [--enable | --disable]
                                   <trunk>

Perhaps you may want to validate this client side before hitting the server.

[Armando Migliaccio (armando-migliaccio)]

Or use the hyphens/dashes translation function available somewhere in the client.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/373847
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[Launchpad Janitor (janitor)]

[Expired for python-neutronclient because there has been no activity for 60 days.]

[Akihiro Motoki (amotoki)]

I think the proposed patch is still valid. Resetting the status to In Progress.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/373847
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=4295dfb8de677d53cf82d6a1364c8e70af7d6de5
Submitter: Jenkins
Branch: master

commit 4295dfb8de677d53cf82d6a1364c8e70af7d6de5
Author: IWAMOTO Toshihiro <email address hidden>
Date: Wed Sep 21 16:48:04 2016 +0900

    Add optional_keys and required_keys to --subport argument

    Change-Id: I2f247076226f06340a49989319065f61f8dd1d3e
    Closes-bug: #1625957

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-neutronclient 6.3.0 release.