Unable to add classless-static-route in extra_dhcp_opt extension

[Shih-Hao Li]

When adding classless-static-route in extra_dhcp_opt for a port, neutron client
complains syntax error. For example,

$ neutron port-update --extra-dhcp-opt opt_name="classless-static-route",opt_value="169.254.169.254/32,20.20.20.1" port1
usage: neutron port-update [-h] [--request-format {json}] [--name NAME]
                           [--description DESCRIPTION]
                           [--fixed-ip subnet_id=SUBNET,ip_address=IP_ADDR]
                           [--device-id DEVICE_ID]
                           [--device-owner DEVICE_OWNER]
                           [--admin-state-up {True,False}]
                           [--security-group SECURITY_GROUP | --no-security-groups]
                           [--extra-dhcp-opt EXTRA_DHCP_OPTS]
                           [--qos-policy QOS_POLICY | --no-qos-policy]
                           [--allowed-address-pair ip_address=IP_ADDR[,mac_address=MAC_ADDR]
                           | --no-allowed-address-pairs]
                           [--dns-name DNS_NAME | --no-dns-name]
                           PORT
neutron port-update: error: argument --extra-dhcp-opt: invalid key-value '20.20.20.1', expected format: key=value
Try 'neutron help port-update' for more information.

The reason is neutron client interprets the "," inside the opt_value as
a delimiter of key-value pairs for --extra-dhcp-opt.

The comma in the opt_value for classless-static-route is required because
the format of DHCP options in the opts file for dnsmasq is like:

tag:<tag_id_or_port_uuid>,option:classless-static-route,169.254.169.254/32,20.20.20.1

[Shih-Hao Li (shihli)]

Here are two possible solutions.

(1) Allow users to use spaces in the opt_value, such as
    opt_value="169.254.169.254/32 20.20.20.1"

    Then edit _generate_opts_per_port() in dhcp.py to convert
    spaces to commas when writing them to opts file.

(2) Modify neutron client to allow commas inside opt_value.

[Shih-Hao Li (shihli)]

The patch for solution (1) is in
https://review.openstack.org/345720

The patch for solution (2) is in
https://review.openstack.org/345717

[Bartek Żurawski (bartekzurawski1)]

What is the status of this bug ? Is it still in progress ?

[Shih-Hao Li (shihli)]

The patch is done and waiting for approval
https://review.openstack.org/345717

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345717
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=494b283eed095346a62ee7024d6099d134aa8144
Submitter: Jenkins
Branch: master

commit 494b283eed095346a62ee7024d6099d134aa8144
Author: Shih-Hao Li <email address hidden>
Date: Wed Aug 24 14:56:49 2016 -0700

    Unable to add classless-static-route in extra_dhcp_opt extension

    When adding classless-static-route in extra_dhcp_opt for a port,
    neutron client complains syntax error. The reason is neutron client
    interprets the "," inside the opt_value as a delimiter of key-value
    pairs for --extra-dhcp-opt.

    This patch modifies neutron client to allow commas inside opt_value.

    This is one of two proposed solutions described in #1605421.

    Change-Id: I8ade427885d11f86d594cecaed96fcb82e38798f
    Closes-Bug: #1605421

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-neutronclient 6.2.0 release.