Remove mox from testing infrastructure in neutronclient for Newton

Bug #1593126 reported by Zhigang Li
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
python-neutronclient
Won't Fix
Low
JianGang Weng

Bug Description

This is to pick up on the work from mitaka for blueprint remove-mox:

https://blueprints.launchpad.net/nova/+spec/remove-mox

We need to do the work in neutronclient for Newton.

Zhigang Li (li-zhigang3)
Changed in neutron:
assignee: nobody → Zhigang Li (li-zhigang3)
affects: neutron → python-neutronclient
Changed in python-neutronclient:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/330933

Changed in python-neutronclient:
assignee: Zhigang Li (li-zhigang3) → Yan Songming (songmingyan)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/330956

Changed in python-neutronclient:
assignee: Yan Songming (songmingyan) → dongwenshuai (dong-wenshuai)
Revision history for this message
bailin.zhang (bailin-zhang) wrote :

At some case, it will assert the parameter types. such as: subnetpool.ListSubnetPool.extend_list(mox.IsA(list), mox.IgnoreArg()). But do not have this function in "mock".So we need add a Class "MatchType" for this.

Changed in python-neutronclient:
assignee: dongwenshuai (dong-wenshuai) → Yan Songming (songmingyan)
Changed in python-neutronclient:
assignee: Yan Songming (songmingyan) → dongwenshuai (dong-wenshuai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/331965

Changed in python-neutronclient:
assignee: dongwenshuai (dong-wenshuai) → LiuYong (liu-yong8)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/331971

Revision history for this message
JianGang Weng (weng-jiangang) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/331986

Changed in python-neutronclient:
assignee: LiuYong (liu-yong8) → JianGang Weng (weng-jiangang)
Changed in python-neutronclient:
assignee: JianGang Weng (weng-jiangang) → dongwenshuai (dong-wenshuai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/332015

Changed in python-neutronclient:
assignee: dongwenshuai (dong-wenshuai) → Bin Lu (369283883-o)
Changed in python-neutronclient:
assignee: Bin Lu (369283883-o) → LiuYong (liu-yong8)
Changed in python-neutronclient:
assignee: LiuYong (liu-yong8) → Yan Songming (songmingyan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/333790

Changed in python-neutronclient:
assignee: Yan Songming (songmingyan) → qinchunhua (qin-chunhua)
Changed in python-neutronclient:
assignee: qinchunhua (qin-chunhua) → LiuYong (liu-yong8)
Changed in python-neutronclient:
assignee: LiuYong (liu-yong8) → QunyingRan (ran-qunying)
Changed in python-neutronclient:
assignee: QunyingRan (ran-qunying) → LiuYong (liu-yong8)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-neutronclient (master)

Change abandoned by LiuYong (<email address hidden>) on branch: master
Review: https://review.openstack.org/331971
Reason: merge conflict

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334840

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-neutronclient (master)

Change abandoned by LiuYong (<email address hidden>) on branch: master
Review: https://review.openstack.org/334840
Reason: depends on conflict

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334849

Changed in python-neutronclient:
assignee: LiuYong (liu-yong8) → Yan Songming (songmingyan)
Changed in python-neutronclient:
assignee: Yan Songming (songmingyan) → LiuYong (liu-yong8)
Changed in python-neutronclient:
assignee: LiuYong (liu-yong8) → Trevor McCasland (twm2016)
Changed in python-neutronclient:
assignee: Trevor McCasland (twm2016) → dongwenshuai (dong-wenshuai)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/330933
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=e917f21bca2b29c762083a152318c2ace0961802
Submitter: Jenkins
Branch: master

commit e917f21bca2b29c762083a152318c2ace0961802
Author: SongmingYan <email address hidden>
Date: Fri Jun 17 03:46:15 2016 -0400

    Fix the problem of mox in test_shell.py

    Use mock instead of mox.

    Change-Id: Ic3938687a5a35e7788e7c2fe0bc562b0d32d96fc
    Partial-Bug: #1593126

Changed in python-neutronclient:
assignee: dongwenshuai (dong-wenshuai) → LiuYong (liu-yong8)
Changed in python-neutronclient:
assignee: LiuYong (liu-yong8) → Bin Lu (369283883-o)
Changed in python-neutronclient:
assignee: Bin Lu (369283883-o) → qinchunhua (qin-chunhua)
Changed in python-neutronclient:
assignee: qinchunhua (qin-chunhua) → JianGang Weng (weng-jiangang)
Changed in python-neutronclient:
assignee: JianGang Weng (weng-jiangang) → qinchunhua (qin-chunhua)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/342015

Changed in python-neutronclient:
assignee: qinchunhua (qin-chunhua) → Zhigang Li (li-zhigang3)
Changed in python-neutronclient:
assignee: Zhigang Li (li-zhigang3) → JianGang Weng (weng-jiangang)
Changed in python-neutronclient:
assignee: JianGang Weng (weng-jiangang) → LiuYong (liu-yong8)
Changed in python-neutronclient:
assignee: LiuYong (liu-yong8) → JianGang Weng (weng-jiangang)
Changed in python-neutronclient:
assignee: JianGang Weng (weng-jiangang) → QunyingRan (ran-qunying)
Changed in python-neutronclient:
assignee: QunyingRan (ran-qunying) → Zhigang Li (li-zhigang3)
Changed in python-neutronclient:
assignee: Zhigang Li (li-zhigang3) → JianGang Weng (weng-jiangang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-neutronclient (master)

Change abandoned by qinchunhua (<email address hidden>) on branch: master
Review: https://review.openstack.org/333790

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/342015
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/330956
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in python-neutronclient:
status: In Progress → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/334849
Reason: neutronclient is deprecated, not worth cleaning up the unit tests.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/331965
Reason: neutronclient is deprecated, not worth cleaning up the unit tests

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/331986
Reason: neutronclient is deprecated, no need to spend effort improving these UTs

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Kevin Benton (<email address hidden>) on branch: master
Review: https://review.openstack.org/332015
Reason: neutronclient is deprecated, let's not spend effort improving the unit tests

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.