stable/* HEADs break packstack installations using stable/liberty puppet definitions

[Ihar Hrachyshka]

If you check out stable/liberty neutronclient now, and try to install OpenStack using packstack, provisioning demo resources, the following installation failure occurs:

ERROR : Error appeared during Puppet run: 172.19.2.4_provision_demo.pp
Error: did not get expected message on network creation, got admin_state_up="True"

This is because older puppet-neutron modules expect 'Created a new network:' message printed on stdout to catch errors; something that was hacked around for mitaka+ with https://github.com/openstack/puppet-neutron/commit/0402147fe00aa7e45e783657df66924c747a59e6

This results in DLRN (RDO trunk) CI jobs failing as in: http://artifacts.ci.centos.org/rdo/jenkins-packstack-gate_khaleesi-rdo-liberty-1033/console.txt.gz

The patch that triggered the failures is: https://review.openstack.org/#/q/Ieb38bd26d26d134d4d274ad2d9f4d1e79fa4e977,n,z

Note it was backported up until Kilo. No new releases were created for stable branches that would include the patch. We are probably safer to revert all those backports and leave just master with the change.

[Ihar Hrachyshka (ihar-hrachyshka)]

I proposed to backport puppet-neutron change to liberty too: https://review.openstack.org/#/c/325802/1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/325804

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/325805

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/325806

[Ihar Hrachyshka (ihar-hrachyshka)]

Client reverts are sharing the same topic: https://review.openstack.org/#/q/topic:cli-output-change-revert

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tony Breeds (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/325806
Reason: This review is being abandoned as the stable/kilo will go End-Of-Life (EOL) in the near future.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/325804
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=8b182c3bbfaf34fc60cfef5ce1ce6bb73c5ea9c7
Submitter: Jenkins
Branch: stable/mitaka

commit 8b182c3bbfaf34fc60cfef5ce1ce6bb73c5ea9c7
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Jun 6 09:58:38 2016 +0000

    Revert "Do not print 'Created' message when using non-table formatter"

    This patch broke DLRN (RDO trunk) CI jobs for stable/liberty. While
    Mitaka release of the Puppet module does not have the issue, we are not
    generally allowed to break external tools.

    Closes-Bug: #1589442
    This reverts commit 0411c5a8d410b39a63df600a08de16df5c82c86d.

    Change-Id: I449174d8bd0de85c072cc8c66e1a3bdae65dcc6b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/325805
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=8f2c11b06497ab67b47a1199a61e5e403458862d
Submitter: Jenkins
Branch: stable/liberty

commit 8f2c11b06497ab67b47a1199a61e5e403458862d
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Jun 6 09:59:07 2016 +0000

    Revert "Do not print 'Created' message when using non-table formatter"

    This patch broke DLRN (RDO trunk) CI jobs for stable/liberty.

    Closes-Bug: #1589442
    This reverts commit 1c8f833fc8e7d49066ed5fad23590aa5b1aed69d.

    Change-Id: I14e46f095685aea9917ddb71c2896be9e71cb042