fixtures 2.0.0 broke stable/liberty python34 gate

[Ihar Hrachyshka]

http://logs.openstack.org/36/258336/4/check/gate-python-neutronclient-python34/668ca60/testr_results.html.gz

More details: http://lists.openstack.org/pipermail/openstack-dev/2016-May/095311.html

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/317889

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/317890

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317889
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=9e4f826166609392ca2a4c64069eb28632ae215d
Submitter: Jenkins
Branch: master

commit 9e4f826166609392ca2a4c64069eb28632ae215d
Author: Ihar Hrachyshka <email address hidden>
Date: Wed May 18 10:09:51 2016 +0200

    tests: removed mocking for Client.get_attr_metadata

    The method is not present since XML support removal:
    I88b0fdd65a649694252d5ff43a174e75026df5b1

    Change-Id: Iaa920a1e9bd37b97ed6f4f5a4d1da05aac20d366
    Related-Bug: #1583029

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317890
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=35ce1a512a92147b0402c5eed9b2aeb1f0f13d87
Submitter: Jenkins
Branch: master

commit 35ce1a512a92147b0402c5eed9b2aeb1f0f13d87
Author: Ihar Hrachyshka <email address hidden>
Date: Wed May 18 09:59:50 2016 +0200

    Switched from fixtures.MonkeyPatch to mock.patch

    fixtures 2.0.0 released a new version of monkey patching fixture that
    triggered issues with patching out class methods in stable/liberty.

    We already stopped relying on fixtures for monkey patching in neutron:
    I58d7a750e263e4af54589ace07ac00bec34b553a and switched to mock there.

    fixtures library is still used for other fixtures, so the dependency
    stays. Mock library is already in the dependency list, so
    test-requirements.txt is not touched.

    Change-Id: If43f3e08ee2235f96b0e5069b0df798a1acb48ea
    Closes-Bug: #1583029

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/318034

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/318035

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/318036

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/318037

[OpenStack Infra (hudson-openstack)]

Change abandoned by Ihar Hrachyshka (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/318036
Reason: That's not right for liberty where the mock is needed.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318034
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=22b25eb50bb91a1475f60f73d68fadf823a6a75b
Submitter: Jenkins
Branch: stable/mitaka

commit 22b25eb50bb91a1475f60f73d68fadf823a6a75b
Author: Ihar Hrachyshka <email address hidden>
Date: Wed May 18 10:09:51 2016 +0200

    tests: removed mocking for Client.get_attr_metadata

    The method is not present since XML support removal:
    I88b0fdd65a649694252d5ff43a174e75026df5b1

    Change-Id: Iaa920a1e9bd37b97ed6f4f5a4d1da05aac20d366
    Related-Bug: #1583029
    (cherry picked from commit 9e4f826166609392ca2a4c64069eb28632ae215d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318035
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=9ff116091e5a4d5b536b3b4d5695fc253621186e
Submitter: Jenkins
Branch: stable/mitaka

commit 9ff116091e5a4d5b536b3b4d5695fc253621186e
Author: Ihar Hrachyshka <email address hidden>
Date: Wed May 18 09:59:50 2016 +0200

    Switched from fixtures.MonkeyPatch to mock.patch

    fixtures 2.0.0 released a new version of monkey patching fixture that
    triggered issues with patching out class methods in stable/liberty.

    We already stopped relying on fixtures for monkey patching in neutron:
    I58d7a750e263e4af54589ace07ac00bec34b553a and switched to mock there.

    fixtures library is still used for other fixtures, so the dependency
    stays. Mock library is already in the dependency list, so
    test-requirements.txt is not touched.

    Change-Id: If43f3e08ee2235f96b0e5069b0df798a1acb48ea
    Closes-Bug: #1583029
    (cherry picked from commit 35ce1a512a92147b0402c5eed9b2aeb1f0f13d87)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318037
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=8570dd1f0ae0bb2277535a9f92d592dfa9bf3d34
Submitter: Jenkins
Branch: stable/liberty

commit 8570dd1f0ae0bb2277535a9f92d592dfa9bf3d34
Author: Ihar Hrachyshka <email address hidden>
Date: Wed May 18 09:59:50 2016 +0200

    Switched from fixtures.MonkeyPatch to mock.patch

    fixtures 2.0.0 released a new version of monkey patching fixture that
    triggered issues with patching out class methods in stable/liberty.

    We already stopped relying on fixtures for monkey patching in neutron:
    I58d7a750e263e4af54589ace07ac00bec34b553a and switched to mock there.

    fixtures library is still used for other fixtures, so the dependency
    stays. Mock library is already in the dependency list, so
    test-requirements.txt is not touched.

    Local changes:
    - also convert get_attr_metadata mock to ... mock. :) In Mitaka+, the
      mock was not needed at all, so we removed it there. For Liberty, we
      need to convert it instead.

    Also include a version cap for keystoneclient since 3.0.0 breaks the
    gate.

    Change-Id: If43f3e08ee2235f96b0e5069b0df798a1acb48ea
    Closes-Bug: #1583029
    (cherry picked from commit 35ce1a512a92147b0402c5eed9b2aeb1f0f13d87)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-neutronclient 5.0.0 release.