allow users to specify tenant_id as positional in quota-show

Bug #1524532 reported by Kevin Benton
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Low
Kevin Benton

Bug Description

"neutron quota-show <tenant-id>" currently throws away the positional argument and gets the quotas for the authenticated tenant. The correct format is "neutron quota-show --tenant-id <tenant-id>".

Due to the silent nature of throwing away the positional, a user not carefully reading the help may end up reading the wrong quotas. We should support the first form of the command as well just to prevent mistakes.

Changed in python-neutronclient:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/255580

Changed in python-neutronclient:
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
importance: Undecided → Low
Changed in python-neutronclient:
assignee: Kevin Benton (kevinbenton) → Akihiro Motoki (amotoki)
Changed in python-neutronclient:
assignee: Akihiro Motoki (amotoki) → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/255580
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=815934c9e1c0abb57cbe87bc0b6d0bd869591c01
Submitter: Jenkins
Branch: master

commit 815934c9e1c0abb57cbe87bc0b6d0bd869591c01
Author: Kevin Benton <email address hidden>
Date: Wed Dec 9 14:55:27 2015 -0800

    Allow tenant_id positional in quota syntax

    This patch allows tenant_id as a positional argument to the
    neutron 'quota-show', 'quota-update', and 'quota-delete' command.
    This is helpful because the positional argument is thrown away
    by default and the calling tenant ID is used instead so a user
    can unexpectedly update or view the wrong quota.

    This syntax is still hidden from the help output to encourage the
    more explicit --tenant-id syntax.

    Closes-Bug: #1524532
    Change-Id: I83d4e0763cc8513a5d608a3754f7d46eaa3f1f6b

Changed in python-neutronclient:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-neutronclient 4.0.0

This issue was fixed in the openstack/python-neutronclient 4.0.0 release.

Akihiro Motoki (amotoki)
Changed in python-neutronclient:
milestone: none → 4.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.