NSX vendor code still present in neutronclient tree

[Henry Gessau]

The NSX specific commands and options should be completely removed from the neutronclient tree. All NSX code and artifacts should be contained in the openstack/vmware-nsx sub-project.

See http://docs.openstack.org/developer/neutron/devref/contribute.html

[Henry Gessau (gessau)]

~/Dev/client-neutron[master] $ git ls-files | grep nsx
neutronclient/neutron/v2_0/nsx/__init__.py
neutronclient/neutron/v2_0/nsx/networkgateway.py
neutronclient/neutron/v2_0/nsx/qos_queue.py
neutronclient/tests/unit/test_cli20_nsx_networkgateway.py
neutronclient/tests/unit/test_cli20_nsx_queue.py

~/Dev/client-neutron[master] $ git grep -i nsx
neutronclient/neutron/v2_0/nsx/networkgateway.py:31: "used for tenant traffic on the NSX gateway node.")
neutronclient/neutron/v2_0/nsx/networkgateway.py:32:CLIENT_CERT_HELP = _("PEM certificate used by the NSX gateway transport node "
neutronclient/neutron/v2_0/nsx/networkgateway.py:33: "to authenticate with the NSX controller.")
neutronclient/neutron/v2_0/nsx/networkgateway.py:35: "NSX gateway transport node to authenticate with "
neutronclient/neutron/v2_0/nsx/networkgateway.py:36: "the NSX controller.")
neutronclient/shell.py:65:from neutronclient.neutron.v2_0.nsx import networkgateway
neutronclient/shell.py:66:from neutronclient.neutron.v2_0.nsx import qos_queue
neutronclient/tests/unit/test_cli20_nsx_networkgateway.py:22:from neutronclient.neutron.v2_0.nsx import networkgateway as nwgw
neutronclient/tests/unit/test_cli20_nsx_queue.py:19:from neutronclient.neutron.v2_0.nsx import qos_queue as qos

[Armando Migliaccio (armando-migliaccio)]

Anyone?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/284826

[Akihiro Motoki (amotoki)]

I checked NSX related neutronclient code and it turns out that we cannot implement the full features with the current client extension. We need to address bug 1549876 first if NSX folks want to keep their feature.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/284826
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/284826
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=d4538462a72e20047221ca510ddfee4b0c3d79a9
Submitter: Jenkins
Branch: master

commit d4538462a72e20047221ca510ddfee4b0c3d79a9
Author: Henry Gessau <email address hidden>
Date: Thu Feb 25 12:22:13 2016 -0500

    Remove the last remaining vendor code

    Partial-Bug: #1520062

    Change-Id: Ibbb03d52d9b2f6af7151aaf7bfdbb4734cea9d16

[Armando Migliaccio (armando-migliaccio)]

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.