oslo_i18n cleanup needed

[Doug Wiegley]

As per the oslo_i18n documentation, neutron/i18n.py should be an internal only module, named _i18n.py. Stuff needed:

- Rename file.
- Add i18n.py with debtcollector references, warning that each repo needs its own, and to stop using.
- Begin migrating subprojects away from shared module.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/250118

[Akihiro Motoki (amotoki)]

I filed another I18n bug 1520094 which is tightly related to this bug.
byg 1520094 I filed depends on this bug. I can help your work.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/250597

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/250985

[OpenStack Infra (hudson-openstack)]

Change abandoned by Akihiro Motoki (<email address hidden>) on branch: master
Review: https://review.openstack.org/250985
Reason: Duplicated with https://review.openstack.org/250071

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/250597
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=c4f3e32e4a942e852c65e8fd93f26147202027f1
Submitter: Jenkins
Branch: master

commit c4f3e32e4a942e852c65e8fd93f26147202027f1
Author: Bo Chi <email address hidden>
Date: Thu Nov 26 21:55:21 2015 -0500

    Switch to internal _i18n pattern, as per oslo_i18n guidelines

    Guidelines referenced from:
    http://docs.openstack.org/developer/oslo.i18n/usage.html

    Change-Id: I2135ebe5faf4b9d3853f634722a885f8ee5a90d5
    Partially-Closes-Bug: #1519493

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/250118
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=c6aa58f673c49d2b53d6bee822840284ae4e4c0d
Submitter: Jenkins
Branch: master

commit c6aa58f673c49d2b53d6bee822840284ae4e4c0d
Author: Doug Wiegley <email address hidden>
Date: Wed Nov 25 18:18:51 2015 -0800

    Switch to internal _i18n pattern, as per oslo_i18n guidelines

    - Guidelines referenced from:
      http://docs.openstack.org/developer/oslo.i18n/usage.html

    Change-Id: Iac380e55ee0e21f40d14acdd1bcba2cb8cc8c826
    Partially-Closes-Bug: #1519493

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/250071
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=dd726ed494db91e9c3e957a6a37e9fd498b5bbc0
Submitter: Jenkins
Branch: master

commit dd726ed494db91e9c3e957a6a37e9fd498b5bbc0
Author: Doug Wiegley <email address hidden>
Date: Wed Nov 25 15:46:19 2015 -0800

    Move i18n to _i18n, as per oslo_i18n guidelines

    - This does NOT break other projects that rely on neutron.i18n,
      as this change includes a debtcollector shim to maintain those
      older entry points, until they can migrate.
    - Also updates _i18n.py to the latest pattern defined by oslo_i18n
    - Guidance and template are from the reference:
      http://docs.openstack.org/developer/oslo.i18n/usage.html

    Partially-Closes-Bug: #1519493
    Change-Id: I1aa3a5fd837d9156da4643a367013c869ed8bf9d

[Akihiro Motoki (amotoki)]

neutronclient review is https://review.openstack.org/#/c/250992/

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron-lbaas 8.0.0.0b1 development milestone.

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron-vpnaas 8.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/250287
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bd36baf3ecfa10c7b8e1e012980feacc605d57e4
Submitter: Jenkins
Branch: master

commit bd36baf3ecfa10c7b8e1e012980feacc605d57e4
Author: Akihiro Motoki <email address hidden>
Date: Thu Nov 26 19:32:32 2015 +0900

    I18n related guideline for subprojects

    Related-Bug: #1519493
    Related-Bug: #1520094
    Change-Id: I183c1f2226ee7aef96b958d888ca3b7a3f9e9a2e

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/250992
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=787ba9250b3dbdd9c0c1b8ee2a4211ba124ee479
Submitter: Jenkins
Branch: master

commit 787ba9250b3dbdd9c0c1b8ee2a4211ba124ee479
Author: Akihiro Motoki <email address hidden>
Date: Sat Nov 28 09:16:42 2015 +0900

    Use _i18n instead of i18n

    It is suggested to use _i18n.py per oslo.i18n document.
    http://docs.openstack.org/developer/oslo.i18n/usage.html

    neutronclient.i18n is now a wrapper module which emits
    the derecation warning. It is because might be used in
    implementation of the client extensions in other repositories.

    Closes-Bug: #1519493
    Change-Id: I44969daeedc9a66dd9ad5bf80617516faf245ecc

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/python-neutronclient 4.0.0 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/266795

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/266795
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=745148817bacacc26ff06a8470cf52c815f6565a
Submitter: Jenkins
Branch: master

commit 745148817bacacc26ff06a8470cf52c815f6565a
Author: IWAMOTO Toshihiro <email address hidden>
Date: Wed Jan 13 18:06:57 2016 +0900

    Convert remaining use of neutronclient.i18n to _i18n

    Change-Id: I77f168af92ae51ce16bed4988bbcaf7c18557727
    Related-Bug: 1519493

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron 8.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Armando Migliaccio (<email address hidden>) on branch: master
Review: https://review.openstack.org/313846
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/313846
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0856095c82b3ef73a0376c741d1a3a61b1a077a6
Submitter: Jenkins
Branch: master

commit 0856095c82b3ef73a0376c741d1a3a61b1a077a6
Author: Fang Zhen <email address hidden>
Date: Sat May 7 16:13:15 2016 +0800

    Remove the file i18n.py and other related cleanups

    As per the oslo_i18n documentation, neutron/i18n.py should be an internal
    only module, named _i18n.py. This was done in Mitaka release and i18n module
    was deprecated since. We could remove the i18n.py now in Newton.

    Closes-bug: #1519493

    Change-Id: I02e33559cef42d90812d9dbc3dac1d8122897e19

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/neutron 9.0.0.0b2 development milestone.